Add: (activities-bookmark-warnings)

Author: alphapapa

README.org

@@ -142,6 +142,7 @@ When option ~activities-bookmark-store~ is enabled, an Emacs bookmark is stored
 
 *Additions*
 + Suggest setting variable ~edebug-inhibit-emacs-lisp-mode-bindings~ to avoid conflicts with suggested keybindings.
++ Option ~activities-bookmark-warnings~ enables warning messages when a non-file-visiting buffer can't be bookmarked (for debugging purposes).
 
 *Changes*
 + Command ~activities-kill~ now discards an activity's last state (while ~activities-suspend~ saves its last state), and closes its frame or tab.

activities.el

@@ -284,6 +284,15 @@ non-nil, the activity's state is not saved."
               (function-item activities--backtrace-visible-p)
               (function :tag "Other predicate")))
 
+(defcustom activities-bookmark-warnings nil
+  "Warn when a buffer can't be bookmarked.
+This is expected to be the case for non-file-visiting buffers
+whose major mode does not provide bookmark support, for which no
+warning is necessary.  This option may be enabled for debugging,
+which will cause a message to be printed for such buffers when an
+activity's state is saved."
+  :type 'boolean)
+
 ;;;; Commands
 
 ;;;###autoload
@@ -616,7 +625,8 @@ activity's name is NAME."
                  (error
                   (pcase (error-message-string err)
                     ("Buffer not visiting a file or directory")
-                    (_ (message (format "Activities: Error while making bookmark for buffer %S: %%S" buffer) err)))
+                    (_ (when activities-bookmark-warnings
+                         (message (format "Activities: Error while making bookmark for buffer %S: %%S" buffer) err))))
                   nil))
      :filename (buffer-file-name buffer)
      :name (buffer-name buffer)

activities.info

@@ -398,6 +398,9 @@ File: README.info,  Node: v05-pre,  Next: v04,  Up: Changelog
 *Additions*
    • Suggest setting variable ‘edebug-inhibit-emacs-lisp-mode-bindings’
      to avoid conflicts with suggested keybindings.
+   • Option ‘activities-bookmark-warnings’ enables warning messages when
+     a non-file-visiting buffer can’t be bookmarked (for debugging
+     purposes).
 
    *Changes*
    • Command ‘activities-kill’ now discards an activity’s last state
@@ -417,6 +420,10 @@ File: README.info,  Node: v05-pre,  Next: v04,  Up: Changelog
    • When discarding an inactive activity, don’t switch to it first.
      (#18 (https://github.com/alphapapa/activity.el/issues/18).  Thanks
      to JD Smith (https://github.com/jdtsmith) for reporting.)
+   • Don’t signal an error when ‘debug-on-error’ is enabled and a buffer
+     is not visiting a file.  (#25
+     (https://github.com/alphapapa/activity.el/issues/25).  Thanks to
+     Karthik Chikmagalur (https://github.com/karthink) for reporting.)
 
 
 File: README.info,  Node: v04,  Next: v033,  Prev: v05-pre,  Up: Changelog
@@ -581,18 +588,18 @@ Node: Bookmarks10053
 Node: FAQ10405
 Node: Changelog13481
 Node: v05-pre13766
-Node: v0414990
-Node: v03315535
-Node: v03215965
-Node: v03116093
-Node: v0316423
-Node: v0216813
-Node: v01317305
-Node: v01217454
-Node: v01117631
-Node: v0117796
-Node: Development17897
-Node: Copyright assignment18169
+Node: v0415411
+Node: v03315956
+Node: v03216386
+Node: v03116514
+Node: v0316844
+Node: v0217234
+Node: v01317726
+Node: v01217875
+Node: v01118052
+Node: v0118217
+Node: Development18318
+Node: Copyright assignment18590
 
 End Tag Table