Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of the HTML elements do not have unique IDs #112

Closed
jakubmiarka opened this issue Sep 13, 2019 · 0 comments
Closed

Some of the HTML elements do not have unique IDs #112

jakubmiarka opened this issue Sep 13, 2019 · 0 comments
Labels
accessibility accessibility-statement
Milestone
2.0.6

Comments

@jakubmiarka
Copy link
Contributor

The IDs in collapsible titles are only replacing the first space with an underscore. Meaning the IDs are likely not unique or not valid.

tech-docs-gem/lib/assets/javascripts/_modules/collapsible-navigation.js

Line 25 in f28d9dc

var id = 'toc-' + $heading.text().toLowerCase().replace(' ', '-')

@NickColley NickColley changed the title The ID attributes in the sidebar are not sanitized properly Some of the HTML elements do not have unique IDs Oct 15, 2019
@NickColley NickColley added this to the 2.0.6 milestone Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility accessibility-statement
Projects
None yet
Milestone
2.0.6
Development

No branches or pull requests
2 participants
@NickColley @jakubmiarka