Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of repos are out-of-sync with this styleguide #73

Closed
41 tasks done
benthorner opened this issue May 13, 2020 · 0 comments · Fixed by alphagov/whitehall#5769
Closed
41 tasks done

Lots of repos are out-of-sync with this styleguide #73

benthorner opened this issue May 13, 2020 · 0 comments · Fixed by alphagov/whitehall#5769

Comments

@benthorner
Copy link
Contributor

benthorner commented May 13, 2020

There's not much point having a styleguide if we're going to ignore it. For new code, it's seldom absolutely necessary to disable a Cop. It's rarely necessary to disable a Cop for an entire repo.

We should try to address this issue by:

  • Removing redundant config e.g. some Metrics/BlockLength overrides
  • Removing overrides that can be auto-corrected
  • Removing overrides that can be manually corrected fairly easily
  • Commenting why any remaining overrides are objectively necessary

Repos this issue applies to:

@benthorner benthorner changed the title Lots of apps override the config from this repo Lots of apps are out of sync with this styleguide May 13, 2020
@benthorner benthorner changed the title Lots of apps are out of sync with this styleguide Lots of apps are out-of-sync with this styleguide May 13, 2020
@benthorner benthorner changed the title Lots of apps are out-of-sync with this styleguide Lots of repos are out-of-sync with this styleguide May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant