Skip to content

Commit 3c9b802

Browse files
committed
Use delegated event handlers for checkboxes
Rather than setting up an event handler on every individual checkbox, set up delegated event handlers on the wrapper. This will significantly reduce the number of event handlers being bound on pages with large numbers of checkboxes (like finder-frontend).
1 parent 14aca54 commit 3c9b802

File tree

1 file changed

+2
-2
lines changed
  • app/assets/javascripts/govuk_publishing_components/components

1 file changed

+2
-2
lines changed

Diff for: app/assets/javascripts/govuk_publishing_components/components/checkboxes.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
1111
var _this = this;
1212
this.applyAriaControlsAttributes(scope);
1313

14-
$(scope).find('[data-nested=true] input[type=checkbox]').on('change', function(e) {
14+
$(scope).on('change', '[data-nested=true] input[type=checkbox]', function(e) {
1515
var checkbox = e.target;
1616
var isNested = $(checkbox).closest('.govuk-checkboxes--nested');
1717
var hasNested = $('.govuk-checkboxes--nested[data-parent=' + checkbox.id + ']');
@@ -23,7 +23,7 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
2323
}
2424
});
2525

26-
$(scope).find('input[type=checkbox]').on('change', function(e) {
26+
$(scope).on('change', 'input[type=checkbox]', function(e) {
2727
if (GOVUK.analytics && GOVUK.analytics.trackEvent) {
2828
var $checkbox = $(e.target);
2929
var category = $checkbox.data("track-category");

0 commit comments

Comments
 (0)