Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Tudor crown spacing (v3) #4711

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

querkmachine
Copy link
Member

Backport changes from #4677 to the v3.x branch.

@querkmachine querkmachine requested a review from a team February 1, 2024 10:48
@querkmachine querkmachine self-assigned this Feb 1, 2024
@querkmachine querkmachine added this to the v3.15.0 milestone Feb 1, 2024
@querkmachine querkmachine force-pushed the adjust-tudor-crown-spacing-v3 branch from b20595e to 60288c7 Compare February 1, 2024 10:51
@querkmachine querkmachine force-pushed the adjust-tudor-crown-spacing-v3 branch from 60288c7 to ef30f17 Compare February 1, 2024 10:54
@querkmachine querkmachine changed the base branch from main to support/3.x February 1, 2024 10:54
@querkmachine querkmachine force-pushed the adjust-tudor-crown-spacing-v3 branch from ef30f17 to 4641769 Compare February 1, 2024 10:55
Copy link
Contributor

@colinrotherham colinrotherham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the v3.x CHANGELOG too like we did in f607a83?

Adjust the spacing of the new Tudor crown to closely match the new SVG Tudor crown to be released in 5.1
@querkmachine querkmachine force-pushed the adjust-tudor-crown-spacing-v3 branch from 4641769 to 7476819 Compare February 1, 2024 11:02
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4711 February 1, 2024 11:02 Inactive
@querkmachine querkmachine marked this pull request as ready for review February 1, 2024 11:03
@querkmachine
Copy link
Member Author

Do we need to update the v3.x CHANGELOG too like we did in f607a83?

Was just doing that. Need to have a PR open so I can link to it in the changelog, after all!

@colinrotherham
Copy link
Contributor

True!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants