-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Tudor crown spacing (v3) #4711
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4711
February 1, 2024 10:48
Inactive
querkmachine
force-pushed
the
adjust-tudor-crown-spacing-v3
branch
from
February 1, 2024 10:51
b20595e
to
60288c7
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4711
February 1, 2024 10:51
Inactive
querkmachine
force-pushed
the
adjust-tudor-crown-spacing-v3
branch
from
February 1, 2024 10:54
60288c7
to
ef30f17
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4711
February 1, 2024 10:54
Inactive
querkmachine
force-pushed
the
adjust-tudor-crown-spacing-v3
branch
from
February 1, 2024 10:55
ef30f17
to
4641769
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4711
February 1, 2024 10:55
Inactive
colinrotherham
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update the v3.x CHANGELOG too like we did in f607a83?
Adjust the spacing of the new Tudor crown to closely match the new SVG Tudor crown to be released in 5.1
querkmachine
force-pushed
the
adjust-tudor-crown-spacing-v3
branch
from
February 1, 2024 11:02
4641769
to
7476819
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4711
February 1, 2024 11:02
Inactive
Was just doing that. Need to have a PR open so I can link to it in the changelog, after all! |
True! |
colinrotherham
approved these changes
Feb 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport changes from #4677 to the v3.x branch.