-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the spacing of the new Tudor crown #4677
Conversation
Adjust the spacing of the new Tudor crown to closely match the new SVG Tudor crown to be released in 5.1
For completion's sake, this PR's header with a product name. Compared with the 5.1 lockup with product name. Slight difference in logotype size but this is to be expected, as the text is slightly different in the new lockup (or subpixel rounding makes it that way, anyway). Overall this seems like a sensible change to me. |
We probably want this tagging onto the end of the existing changelog entry before I put approval on it. You can do this if you want, or someone on the team can handle it otherwise. Then it'll need a second approval before merging. |
Thanks, I've just added a changelog entry to reference this PR, hope this is OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing and handling this!
ddece07
to
f607a83
Compare
No problem, thanks very much for the reviewing so quickly. Do I also need to request a 2nd review before it can be merged? thanks |
@MartinJJones Yep, just need someone else on the team to review it and we should be good. The same tweaks are probably worth doing on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks so much for spotting and sorting this @MartinJJones !
Thanks again for reviewing the changes, much appreciated 😃 |
Adjust the spacing of the new Tudor crown to closely match the new SVG Tudor crown to be released in 5.1.
Visual Changes
4.8 - Before
Screenshot
Video comparison, switching from 4.8 to 5.1
4.8-5.1-before.mov
4.8 - After
Screenshot
Video comparison, switching from 4.8 to 5.1
4.8-5.1-after.mov