Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the spacing of the new Tudor crown #4677

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

MartinJJones
Copy link

@MartinJJones MartinJJones commented Jan 26, 2024

Adjust the spacing of the new Tudor crown to closely match the new SVG Tudor crown to be released in 5.1.

Visual Changes

4.8 - Before

Screenshot
localhost_3000_components_header_with-Tudor-crown_preview-before

Video comparison, switching from 4.8 to 5.1

4.8-5.1-before.mov

4.8 - After

Screenshot
localhost_3000_components_header_with-Tudor-crown_preview-after

Video comparison, switching from 4.8 to 5.1

4.8-5.1-after.mov

Adjust the spacing of the new Tudor crown to closely match the new SVG Tudor crown to be released in 5.1
@MartinJJones MartinJJones marked this pull request as ready for review January 29, 2024 09:32
@querkmachine
Copy link
Member

For completion's sake, this PR's header with a product name.

Compared with the 5.1 lockup with product name. Slight difference in logotype size but this is to be expected, as the text is slightly different in the new lockup (or subpixel rounding makes it that way, anyway).

Animation comparing this PR with the 5.1 logo with product name

In Chromium:
Logo with product name in Chromium

In Safari:
Logo with product name in Safari

In Firefox:
Logo with product name in Firefox

Overall this seems like a sensible change to me.

@querkmachine
Copy link
Member

We probably want this tagging onto the end of the existing changelog entry before I put approval on it. You can do this if you want, or someone on the team can handle it otherwise.

Then it'll need a second approval before merging.

@MartinJJones
Copy link
Author

We probably want this tagging onto the end of the existing changelog entry before I put approval on it. You can do this if you want, or someone on the team can handle it otherwise.

Thanks, I've just added a changelog entry to reference this PR, hope this is OK

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@querkmachine querkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and handling this!

@MartinJJones MartinJJones force-pushed the adjust-tudor-crown-spacing branch from ddece07 to f607a83 Compare January 30, 2024 10:29
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4677 January 30, 2024 10:30 Inactive
@MartinJJones
Copy link
Author

MartinJJones commented Jan 30, 2024

Thanks for noticing and handling this!

No problem, thanks very much for the reviewing so quickly.

Do I also need to request a 2nd review before it can be merged? thanks

@querkmachine
Copy link
Member

@MartinJJones Yep, just need someone else on the team to review it and we should be good.

The same tweaks are probably worth doing on the support/3.x branch too, but we can probably handle that now we're confident of the changes here.

@querkmachine querkmachine requested a review from a team January 30, 2024 11:13
Copy link
Member

@christopherthomasdesign christopherthomasdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks so much for spotting and sorting this @MartinJJones !

@querkmachine querkmachine merged commit 95dc753 into support/4.x Feb 1, 2024
39 checks passed
@querkmachine querkmachine deleted the adjust-tudor-crown-spacing branch February 1, 2024 10:35
@querkmachine querkmachine restored the adjust-tudor-crown-spacing branch February 1, 2024 10:35
@querkmachine querkmachine added this to the v4.8.0 milestone Feb 1, 2024
@MartinJJones
Copy link
Author

Thanks again for reviewing the changes, much appreciated 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants