From d481607b2f211cb7f4622d19af54d2b8eb7f6117 Mon Sep 17 00:00:00 2001 From: beeps Date: Thu, 4 Jan 2024 11:24:23 +0000 Subject: [PATCH] Bump minimum Node version, allow using npm v10 Node 18.19.0 updated the npm dependency to version 10.2.3. https://nodejs.org/en/blog/release/v18.19.0 This would break fresh builds of Frontend v4 as a user would automatically get the latest Node 18 version but simultaneously get an npm version not in our allowed range. Additionally increases the minimum Node version to 18.17.0, as this is the earliest version of Node still supported by npm 10.x. --- app/package.json | 4 ++-- package-lock.json | 26 +++++++++++++------------- package.json | 4 ++-- shared/config/package.json | 4 ++-- shared/helpers/package.json | 4 ++-- shared/lib/package.json | 4 ++-- shared/tasks/package.json | 4 ++-- 7 files changed, 25 insertions(+), 25 deletions(-) diff --git a/app/package.json b/app/package.json index 51122d334d..03874ecaee 100644 --- a/app/package.json +++ b/app/package.json @@ -4,8 +4,8 @@ "description": "GOV.UK Frontend review app", "main": "src/start.mjs", "engines": { - "node": "^18.12.0", - "npm": "^8.1.0 || ^9.1.0" + "node": "^18.17.0", + "npm": "^8.1.0 || ^9.1.0 || ^10.1.0" }, "license": "MIT", "scripts": { diff --git a/package-lock.json b/package-lock.json index 352621ec4a..e3d6a416e6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -69,8 +69,8 @@ "typescript": "^5.0.4" }, "engines": { - "node": "^18.12.0", - "npm": "^8.1.0 || ^9.1.0" + "node": "^18.17.0", + "npm": "^8.1.0 || ^9.1.0 || ^10.1.0" }, "optionalDependencies": { "@jest/environment": "^29.5.0", @@ -115,8 +115,8 @@ "supertest": "^6.3.3" }, "engines": { - "node": "^18.12.0", - "npm": "^8.1.0 || ^9.1.0" + "node": "^18.17.0", + "npm": "^8.1.0 || ^9.1.0 || ^10.1.0" } }, "app/node_modules/express-validator": { @@ -26865,7 +26865,7 @@ }, "package": { "name": "govuk-frontend", - "version": "4.6.0", + "version": "4.7.0", "license": "MIT", "engines": { "node": ">= 4.2.0" @@ -26878,8 +26878,8 @@ "govuk-frontend": "*" }, "engines": { - "node": "^18.12.0", - "npm": "^8.1.0 || ^9.1.0" + "node": "^18.17.0", + "npm": "^8.1.0 || ^9.1.0 || ^10.1.0" } }, "shared/helpers": { @@ -26901,8 +26901,8 @@ "sass-embedded": "^1.60.0" }, "engines": { - "node": "^18.12.0", - "npm": "^8.1.0 || ^9.1.0" + "node": "^18.17.0", + "npm": "^8.1.0 || ^9.1.0 || ^10.1.0" } }, "shared/lib": { @@ -26916,8 +26916,8 @@ "minimatch": "^9.0.0" }, "engines": { - "node": "^18.12.0", - "npm": "^8.1.0 || ^9.1.0" + "node": "^18.17.0", + "npm": "^8.1.0 || ^9.1.0 || ^10.1.0" } }, "shared/tasks": { @@ -26950,8 +26950,8 @@ "yargs-parser": "^21.1.1" }, "engines": { - "node": "^18.12.0", - "npm": "^8.1.0 || ^9.1.0" + "node": "^18.17.0", + "npm": "^8.1.0 || ^9.1.0 || ^10.1.0" } }, "shared/tasks/node_modules/@percy/sdk-utils": { diff --git a/package.json b/package.json index 4db50f9c73..6acf1359b5 100644 --- a/package.json +++ b/package.json @@ -3,8 +3,8 @@ "name": "govuk-frontend-repository", "description": "Used only for the development of GOV.UK Frontend, see `package/package.json` for the published `package.json`", "engines": { - "node": "^18.12.0", - "npm": "^8.1.0 || ^9.1.0" + "node": "^18.17.0", + "npm": "^8.1.0 || ^9.1.0 || ^10.1.0" }, "license": "MIT", "workspaces": [ diff --git a/shared/config/package.json b/shared/config/package.json index d3d05fa08f..3e0599b318 100644 --- a/shared/config/package.json +++ b/shared/config/package.json @@ -4,8 +4,8 @@ "description": "GOV.UK Frontend shared config", "main": "index.js", "engines": { - "node": "^18.12.0", - "npm": "^8.1.0 || ^9.1.0" + "node": "^18.17.0", + "npm": "^8.1.0 || ^9.1.0 || ^10.1.0" }, "license": "MIT", "dependencies": { diff --git a/shared/helpers/package.json b/shared/helpers/package.json index 4e8d4a8346..951892016a 100644 --- a/shared/helpers/package.json +++ b/shared/helpers/package.json @@ -9,8 +9,8 @@ "./*": "./*.js" }, "engines": { - "node": "^18.12.0", - "npm": "^8.1.0 || ^9.1.0" + "node": "^18.17.0", + "npm": "^8.1.0 || ^9.1.0 || ^10.1.0" }, "license": "MIT", "devDependencies": { diff --git a/shared/lib/package.json b/shared/lib/package.json index 2ca314b4b6..494585e079 100644 --- a/shared/lib/package.json +++ b/shared/lib/package.json @@ -8,8 +8,8 @@ "./*": "./*.js" }, "engines": { - "node": "^18.12.0", - "npm": "^8.1.0 || ^9.1.0" + "node": "^18.17.0", + "npm": "^8.1.0 || ^9.1.0 || ^10.1.0" }, "license": "MIT", "dependencies": { diff --git a/shared/tasks/package.json b/shared/tasks/package.json index 4818192f78..864faa1a51 100644 --- a/shared/tasks/package.json +++ b/shared/tasks/package.json @@ -4,8 +4,8 @@ "description": "GOV.UK Frontend shared tasks", "main": "index.mjs", "engines": { - "node": "^18.12.0", - "npm": "^8.1.0 || ^9.1.0" + "node": "^18.17.0", + "npm": "^8.1.0 || ^9.1.0 || ^10.1.0" }, "license": "MIT", "devDependencies": {