Skip to content

Commit

Permalink
Bump govuk_publishing_components to 9.9.1
Browse files Browse the repository at this point in the history
This version removes headings from the document list component. This caused a couple of tests to fail which have also been fixed in this commit.
  • Loading branch information
Vanita Barrett committed Aug 6, 2018
1 parent e6d6d13 commit fa93417
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ gem 'gds-api-adapters', '~> 52.7'
gem 'govuk_ab_testing', '~> 2.4'
gem 'govuk_app_config', '~> 1.8'
gem 'govuk_frontend_toolkit', '~> 7.6'
gem 'govuk_publishing_components', '~> 9.9.0'
gem 'govuk_publishing_components', '~> 9.9.1'
gem 'plek', '~> 2.1'
gem 'slimmer', '~> 13.0'

Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ GEM
govuk_frontend_toolkit (7.6.0)
railties (>= 3.1.0)
sass (>= 3.2.0)
govuk_publishing_components (9.9.0)
govuk_publishing_components (9.9.1)
govspeak (>= 5.0.3)
govuk_app_config
govuk_frontend_toolkit
Expand Down Expand Up @@ -365,7 +365,7 @@ DEPENDENCIES
govuk_ab_testing (~> 2.4)
govuk_app_config (~> 1.8)
govuk_frontend_toolkit (~> 7.6)
govuk_publishing_components (~> 9.9.0)
govuk_publishing_components (~> 9.9.1)
govuk_schemas (~> 3.2)
htmlentities (~> 4.3)
jasmine-rails
Expand Down
4 changes: 2 additions & 2 deletions test/integration/document_collection_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class DocumentCollectionTest < ActionDispatch::IntegrationTest
documents = @content_item["links"]["documents"]

documents.each do |doc|
assert page.has_css?('.gem-c-document-list__item-title a', text: doc["title"])
assert page.has_css?('.gem-c-document-list__item-title', text: doc["title"])
end

assert page.has_css?('.gem-c-document-list .gem-c-document-list__item', count: documents.count)
Expand All @@ -101,7 +101,7 @@ class DocumentCollectionTest < ActionDispatch::IntegrationTest
groups = page.all('.gem-c-document-list')
assert page.has_css?('[data-module="track-click"]'), count: groups.length

first_section_links = groups.first.all('.gem-c-document-list__item-title a')
first_section_links = groups.first.all('.gem-c-document-list__item-title')
first_link = first_section_links.first

assert_equal(
Expand Down

0 comments on commit fa93417

Please sign in to comment.