From 223cd0af1c50fa624bd69d57c4b976d966777df2 Mon Sep 17 00:00:00 2001 From: Jon Hallam Date: Tue, 11 Feb 2020 13:04:49 +0000 Subject: [PATCH] Rename "Print ISBN" to "ISBN" Following https://github.com/alphagov/government-frontend/pull/1649 Web ISBN has been removed. This left us with "Print ISBN" which sounds a bit odd if there are no other ISBN's. This renames "Print ISBN" to make things a bit clearer. --- .../content_items/html_publication/_print_meta_data.html.erb | 2 +- test/integration/html_publication_test.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/views/content_items/html_publication/_print_meta_data.html.erb b/app/views/content_items/html_publication/_print_meta_data.html.erb index 43ffb5e89..54b880dd5 100644 --- a/app/views/content_items/html_publication/_print_meta_data.html.erb +++ b/app/views/content_items/html_publication/_print_meta_data.html.erb @@ -16,6 +16,6 @@ <% unless @content_item.isbn.blank? %>

- Print ISBN: <%= @content_item.isbn %> + ISBN: <%= @content_item.isbn %>

<% end %> diff --git a/test/integration/html_publication_test.rb b/test/integration/html_publication_test.rb index 78ad58d30..2598f1b55 100644 --- a/test/integration/html_publication_test.rb +++ b/test/integration/html_publication_test.rb @@ -30,7 +30,7 @@ class HtmlPublicationTest < ActionDispatch::IntegrationTest assert page.find(".print-meta-data", visible: false) assert page.has_no_text?("© Crown copyright #{@content_item['details']['public_timestamp'].to_date.year}") - assert page.has_no_text?("Print ISBN: #{@content_item['details']['isbn']}") + assert page.has_no_text?("ISBN: #{@content_item['details']['isbn']}") end end @@ -41,7 +41,7 @@ class HtmlPublicationTest < ActionDispatch::IntegrationTest assert page.find(".print-meta-data", visible: true) assert page.has_text?("© Crown copyright #{@content_item['details']['public_timestamp'].to_date.year}") - assert page.has_text?("Print ISBN: #{@content_item['details']['isbn']}") + assert page.has_text?("ISBN: #{@content_item['details']['isbn']}") end end