From f8c446301b9930a42bf4c8a48bc762efc40e9531 Mon Sep 17 00:00:00 2001
From: Karl Baker <karl.baker@digital.cabinet-office.gov.uk>
Date: Wed, 20 Mar 2019 16:28:10 +0000
Subject: [PATCH] Update variant for Related Links A/B test v4

This commit updates the A/B test variant for related links from RelatedLinksABTest3 to RelatedLinksABTest4. This is to support the fourth iteration of the A/B test which is using a new set of related link data.
---
 app/controllers/concerns/ab_testable.rb          |  2 +-
 .../controllers/content_items_controller_test.rb | 16 ++++++++--------
 test/controllers/development_controller_test.rb  |  4 ++--
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/app/controllers/concerns/ab_testable.rb b/app/controllers/concerns/ab_testable.rb
index c52703bac..f91753667 100644
--- a/app/controllers/concerns/ab_testable.rb
+++ b/app/controllers/concerns/ab_testable.rb
@@ -16,7 +16,7 @@ def related_links_variant
 
   def related_links_test
     @related_links_test ||= GovukAbTesting::AbTest.new(
-      "RelatedLinksABTest3",
+      "RelatedLinksABTest4",
       dimension: RELATED_LINKS_DIMENSION,
       allowed_variants: %w(A B C),
       control_variant: "A"
diff --git a/test/controllers/content_items_controller_test.rb b/test/controllers/content_items_controller_test.rb
index 5b4351143..7eaa2ddfc 100644
--- a/test/controllers/content_items_controller_test.rb
+++ b/test/controllers/content_items_controller_test.rb
@@ -130,8 +130,8 @@ class ContentItemsControllerTest < ActionController::TestCase
     assert_equal content_item['title'], assigns[:content_item].title
   end
 
-  test "gets item from the content store and keeps ordered_related_items when running RelatedLinksABTest3 misclassification variant" do
-    with_variant RelatedLinksABTest3: 'A' do
+  test "gets item from the content store and keeps ordered_related_items when running RelatedLinksABTest4 misclassification variant" do
+    with_variant RelatedLinksABTest4: 'A' do
       content_item = content_store_has_schema_example('case_study', 'case_study')
 
       get :show, params: { path: path_for(content_item) }
@@ -140,8 +140,8 @@ class ContentItemsControllerTest < ActionController::TestCase
     end
   end
 
-  test "gets item from the content store and keeps ordered_related_items when running RelatedLinksABTest3 control variant" do
-    with_variant RelatedLinksABTest3: 'B' do
+  test "gets item from the content store and keeps ordered_related_items when running RelatedLinksABTest4 control variant" do
+    with_variant RelatedLinksABTest4: 'B' do
       content_item = content_store_has_schema_example('case_study', 'case_study')
 
       get :show, params: { path: path_for(content_item) }
@@ -150,8 +150,8 @@ class ContentItemsControllerTest < ActionController::TestCase
     end
   end
 
-  test "gets item from the content store and replaces ordered_related_items when running RelatedLinksABTest3 test variant" do
-    with_variant RelatedLinksABTest3: 'C' do
+  test "gets item from the content store and replaces ordered_related_items when running RelatedLinksABTest4 test variant" do
+    with_variant RelatedLinksABTest4: 'C' do
       content_item = content_store_has_schema_example('case_study', 'case_study')
 
       get :show, params: { path: path_for(content_item) }
@@ -160,8 +160,8 @@ class ContentItemsControllerTest < ActionController::TestCase
     end
   end
 
-  test "gets item from the content store and replaces ordered_related_items when empty array when RelatedLinksABTest3 test variant has no suggestions" do
-    with_variant RelatedLinksABTest3: 'C' do
+  test "gets item from the content store and replaces ordered_related_items when empty array when RelatedLinksABTest4 test variant has no suggestions" do
+    with_variant RelatedLinksABTest4: 'C' do
       content_item = content_store_has_schema_example('guide', 'guide')
 
       get :show, params: { path: path_for(content_item) }
diff --git a/test/controllers/development_controller_test.rb b/test/controllers/development_controller_test.rb
index 347e60616..983e0e56d 100644
--- a/test/controllers/development_controller_test.rb
+++ b/test/controllers/development_controller_test.rb
@@ -4,8 +4,8 @@ class DevelopmentControllerTest < ActionController::TestCase
   include GovukAbTesting::MinitestHelpers
 
   %w(A B C).each do |test_variant|
-    test "RelatedLinksABTest3 works correctly for each variant (variant: #{test_variant})" do
-      with_variant RelatedLinksABTest3: test_variant do
+    test "RelatedLinksABTest4 works correctly for each variant (variant: #{test_variant})" do
+      with_variant RelatedLinksABTest4: test_variant do
         get :index
 
         ab_test = @controller.send(:related_links_test)