PR comments addressed

- move the URL definition on which the script to run further up
- added alt text to the logos
- removed a redundant ID

Author: Jakub Miarka

app/assets/javascripts/modules/show-gov-uk-verify-hint.js

@@ -5,10 +5,11 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
   'use strict'
 
   var $ = global.jQuery
+  var VISIBLE_ON_URL = "/personal-tax-account/sign-in/prove-identity"
 
   GOVUK.Modules.ShowGovUkVerifyHint = function () {
     this.start = function (element) {
-      if (window.location.href.indexOf("/personal-tax-account/sign-in/prove-identity") > -1) {
+      if (window.location.href.indexOf(VISIBLE_ON_URL) > -1) {
         checkLastSuccessfulIdp(element)
       }
     }
@@ -44,12 +45,12 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
                   '<img ' +
                     'class="verify-hint-logos-idp"' +
                     'src="https://gds-verify-frontend-assets.s3.amazonaws.com/4af94ca-c1e26b4/'+ data['simpleId'] +'.png"' +
-                    'alt=""'+
+                    'alt="' + data['displayName'] + '"'+
                   '>' +
                   '<img '+
                     'class="verify-hint-logos-verify"' +
                     'src="https://gds-verify-frontend-assets.s3.amazonaws.com/4af94ca-c1e26b4/govuk-verify-small-black-text-454fe97ff5e3edfb6eebdc648930c0ff675616ae7956f1d87e67b30f479d7b8d.svg"' +
-                    'alt=""' +
+                    'alt="GOV.UK Verify logo"' +
                   '>' +
                 '</div>' +
                 '<a '+

app/assets/stylesheets/views/_choose_sign_in.scss

@@ -1,5 +1,4 @@
 .verify-hint-box {
-  width: 100%;
   border: 5px solid $govuk-border-colour;
   padding: govuk-spacing(3);
   box-sizing: border-box;

app/views/content_items/service_sign_in/_choose_sign_in.html.erb

@@ -27,7 +27,7 @@
   <%= render "govuk_publishing_components/components/fieldset", legend_text: legend_text do %>
     <div class="govuk-grid-row">
       <div class="govuk-grid-column-two-thirds">
-      <div id="verify-hint" data-module="show-gov-uk-verify-hint" style="display:none"></div>
+      <div data-module="show-gov-uk-verify-hint"></div>
         <%= render 'govuk_publishing_components/components/govspeak', content: raw(@content_item.description) %>
         <% if @error %>
           <%= render "components/error-message", text: t('service_sign_in.error.option') %>

spec/javascripts/show-gov-uk-verify-hint.spec.js

@@ -10,7 +10,7 @@ describe('A GOV.UK Verify hint box', function () {
 
   beforeEach(function () {
 
-    element = $('<div id="verify-hint" style="display:none"></div>')
+    element = $('<div style="display:none"></div>')
 
     hint = new GOVUK.Modules.ShowGovUkVerifyHint()
     hint.start(element)