' +
@@ -108,40 +105,5 @@ describe('Webchat', function () {
expect($advisersBusy.hasClass('govuk-!-display-none')).toBe(true)
expect($advisersUnavailable.hasClass('govuk-!-display-none')).toBe(true)
})
-
- it('should only track once per state change', function () {
- var analyticsExpects = ['available', 'error']
- var analyticsReceived = []
- var analyticsCalled = 0
- var clock = lolex.install()
-
- spyOn(GOVUK.analytics, 'trackEvent').and.callFake(function (webchatKey, webchatValue) {
- analyticsReceived.push(webchatValue)
- analyticsCalled++
- })
-
- mount()
- jasmine.Ajax.requests.mostRecent().respondWith(jsonNormalisedAvailable)
-
- expect($advisersAvailable.hasClass('govuk-!-display-none')).toBe(false)
-
- expect($advisersBusy.hasClass('govuk-!-display-none')).toBe(true)
- expect($advisersError.hasClass('govuk-!-display-none')).toBe(true)
- expect($advisersUnavailable.hasClass('govuk-!-display-none')).toBe(true)
-
- clock.tick(POLL_INTERVAL)
- jasmine.Ajax.requests.mostRecent().respondWith(jsonNormalisedError)
-
- expect($advisersError.hasClass('govuk-!-display-none')).toBe(false)
- expect($advisersAvailable.hasClass('govuk-!-display-none')).toBe(true)
- expect($advisersBusy.hasClass('govuk-!-display-none')).toBe(true)
- expect($advisersUnavailable.hasClass('govuk-!-display-none')).toBe(true)
- expect(analyticsCalled).toBe(2)
- expect(analyticsReceived).toEqual(analyticsExpects)
- clock.tick(POLL_INTERVAL)
- expect(analyticsCalled).toBe(2)
- expect(analyticsReceived).toEqual(analyticsExpects)
- clock.uninstall()
- })
})
})
diff --git a/test/components/important_metadata_test.rb b/test/components/important_metadata_test.rb
index 75d5a9c01..660c5d989 100644
--- a/test/components/important_metadata_test.rb
+++ b/test/components/important_metadata_test.rb
@@ -53,9 +53,4 @@ def component_name
assert_select ".app-c-important-metadata dd a[href='https://www.gov.uk/cma-cases?outcome_type%5B%5D=mergers-phase-2-clearance-with-remedies']",
text: "Mergers - phase 2 clearance with remedies"
end
-
- test "link tracking is enabled" do
- render_component(items: { "Case type": ["
Mergers"] })
- assert_select ".app-c-important-metadata dl[data-module='gem-track-click']"
- end
end
diff --git a/test/integration/consultation_test.rb b/test/integration/consultation_test.rb
index 24f5d51d5..a1ba7e8a3 100644
--- a/test/integration/consultation_test.rb
+++ b/test/integration/consultation_test.rb
@@ -378,11 +378,11 @@ class ConsultationTest < ActionDispatch::IntegrationTest
buttons = page.find_all(:button)
- expected_tracking_top = single_page_notification_button_ga_tracking(1, "Top")
+ expected_tracking_top = single_page_notification_button_ga4_tracking(1, "Top")
actual_tracking_top = JSON.parse(buttons.first["data-ga4-link"])
assert_equal expected_tracking_top, actual_tracking_top
- expected_tracking_bottom = single_page_notification_button_ga_tracking(2, "Footer")
+ expected_tracking_bottom = single_page_notification_button_ga4_tracking(2, "Footer")
actual_tracking_bottom = JSON.parse(buttons.last["data-ga4-link"])
assert_equal expected_tracking_bottom, actual_tracking_bottom
end
diff --git a/test/integration/detailed_guide_test.rb b/test/integration/detailed_guide_test.rb
index 19e5afd47..94ba6c670 100644
--- a/test/integration/detailed_guide_test.rb
+++ b/test/integration/detailed_guide_test.rb
@@ -93,11 +93,11 @@ class DetailedGuideTest < ActionDispatch::IntegrationTest
buttons = page.find_all(:button)
- expected_tracking_top = single_page_notification_button_ga_tracking(1, "Top")
+ expected_tracking_top = single_page_notification_button_ga4_tracking(1, "Top")
actual_tracking_top = JSON.parse(buttons.first["data-ga4-link"])
assert_equal expected_tracking_top, actual_tracking_top
- expected_tracking_bottom = single_page_notification_button_ga_tracking(2, "Footer")
+ expected_tracking_bottom = single_page_notification_button_ga4_tracking(2, "Footer")
actual_tracking_bottom = JSON.parse(buttons.last["data-ga4-link"])
assert_equal expected_tracking_bottom, actual_tracking_bottom
end
diff --git a/test/integration/document_collection_test.rb b/test/integration/document_collection_test.rb
index 21f93cd7b..d6caaaf00 100644
--- a/test/integration/document_collection_test.rb
+++ b/test/integration/document_collection_test.rb
@@ -93,48 +93,6 @@ class DocumentCollectionTest < ActionDispatch::IntegrationTest
end
end
- test "includes tracking data on all collection documents" do
- setup_and_visit_content_item("document_collection")
- groups = page.all(".gem-c-document-list")
- assert page.has_css?('[data-module="gem-track-click"]'), count: groups.length
-
- first_section_links = groups.first.all(:link)
- first_link = first_section_links.first
-
- assert_equal(
- "navDocumentCollectionLinkClicked",
- first_link["data-track-category"],
- "Expected a tracking category to be set in the data attributes",
- )
-
- assert_equal(
- "1.1",
- first_link["data-track-action"],
- "Expected the link position to be set in the data attributes",
- )
-
- assert_match(
- first_link["data-track-label"],
- first_link[:href],
- "Expected the content item base path to be set in the data attributes",
- )
- assert first_link["data-track-options"].present?
-
- data_options = JSON.parse(first_link["data-track-options"])
-
- assert_equal(
- first_section_links.count.to_s,
- data_options["dimension28"],
- "Expected the total number of content items within the section to be present in the tracking options",
- )
-
- assert_equal(
- first_link.text,
- data_options["dimension29"],
- "Expected the subtopic title to be present in the tracking options",
- )
- end
-
test "withdrawn collection" do
setup_and_visit_content_item("document_collection_withdrawn")
assert page.has_css?("title", text: "[Withdrawn]", visible: false)
diff --git a/test/integration/publication_test.rb b/test/integration/publication_test.rb
index db20a20c0..2e426a5b0 100644
--- a/test/integration/publication_test.rb
+++ b/test/integration/publication_test.rb
@@ -275,11 +275,11 @@ class PublicationTest < ActionDispatch::IntegrationTest
buttons = page.find_all(:button)
- expected_tracking_top = single_page_notification_button_ga_tracking(1, "Top")
+ expected_tracking_top = single_page_notification_button_ga4_tracking(1, "Top")
actual_tracking_top = JSON.parse(buttons.first["data-ga4-link"])
assert_equal expected_tracking_top, actual_tracking_top
- expected_tracking_bottom = single_page_notification_button_ga_tracking(2, "Footer")
+ expected_tracking_bottom = single_page_notification_button_ga4_tracking(2, "Footer")
actual_tracking_bottom = JSON.parse(buttons.last["data-ga4-link"])
assert_equal expected_tracking_bottom, actual_tracking_bottom
end
diff --git a/test/integration/service_sign_in/choose_sign_in_test.rb b/test/integration/service_sign_in/choose_sign_in_test.rb
index 15b62380b..97f177403 100644
--- a/test/integration/service_sign_in/choose_sign_in_test.rb
+++ b/test/integration/service_sign_in/choose_sign_in_test.rb
@@ -10,10 +10,6 @@ class ChooseSignInTest < ActionDispatch::IntegrationTest
assert_not page.has_css?("#proposition-menu")
assert page.has_css?('.gem-c-back-link[href="/log-in-file-self-assessment-tax-return"]', text: "Back")
- assert page.has_css?('form[data-module="track-radio-group set-ga-client-id-on-form"]')
- assert page.has_css?("form[data-tracking-code='UA-xxxxxx']")
- assert page.has_css?("form[data-tracking-domain='tax.service.gov.uk']")
- assert page.has_css?("form[data-tracking-name='somethingClicky']")
within "#content form" do
within ".gem-c-fieldset" do
diff --git a/test/presenters/content_item/parts_test.rb b/test/presenters/content_item/parts_test.rb
index 19fb22e85..8db010f24 100644
--- a/test/presenters/content_item/parts_test.rb
+++ b/test/presenters/content_item/parts_test.rb
@@ -152,19 +152,6 @@ def requested_path
assert_equal @parts.current_part_title, "first-title"
end
- test "navigation items are presented as trackable links unless they are the current part" do
- presenting_first_part_in_content_item
- assert_equal @parts.current_part_title, "first-title"
- assert_equal @parts.parts_navigation,
- [[
- "first-title",
- "
second-title",
- ]]
- end
-
test "links to the first part ignore the part's slug and use the base path" do
presenting_second_part_in_content_item
assert_equal @parts.current_part_title, "second-title"
@@ -218,19 +205,13 @@ def content_item
[
[
"first-title",
- "
second-title",
],
[
- "
third-title",
- "
fourth-title",
],
]
diff --git a/test/presenters/document_collection_presenter_test.rb b/test/presenters/document_collection_presenter_test.rb
index d166b929f..35d5c13f2 100644
--- a/test/presenters/document_collection_presenter_test.rb
+++ b/test/presenters/document_collection_presenter_test.rb
@@ -53,15 +53,6 @@ class PresentedDocumentCollection < TestCase
link: {
text: "National standard for driving cars and light vans",
path: "/government/publications/national-standard-for-driving-cars-and-light-vans",
- data_attributes: {
- track_category: "navDocumentCollectionLinkClicked",
- track_action: "1.1",
- track_label: "/government/publications/national-standard-for-driving-cars-and-light-vans",
- track_options: {
- dimension28: "1",
- dimension29: "National standard for driving cars and light vans",
- },
- },
},
metadata: {
public_updated_at: Time.zone.parse("2007-03-16 15:00:02 +0000"),
@@ -71,7 +62,7 @@ class PresentedDocumentCollection < TestCase
]
document_ids = schema_item["details"]["collection_groups"].first["documents"]
- assert_equal documents, presented_item.group_document_links({ "documents" => [document_ids.first] }, 0)
+ assert_equal documents, presented_item.group_document_links({ "documents" => [document_ids.first] })
end
test "it handles the document type lacking a translation" do
@@ -83,7 +74,6 @@ class PresentedDocumentCollection < TestCase
grouped = present_example(schema_data).group_document_links(
{ "documents" => [document["content_id"]] },
- 0,
)
assert_nil grouped.first[:metadata][:document_type]
@@ -98,7 +88,6 @@ class PresentedDocumentCollection < TestCase
grouped = present_example(schema_data).group_document_links(
{ "documents" => [document["content_id"]] },
- 0,
)
assert_nil grouped.first[:metadata][:public_updated_at]
@@ -123,7 +112,6 @@ class PresentedDocumentCollection < TestCase
grouped = present_example(schema_data).group_document_links(
{ "documents" => [document["content_id"]] },
- 0,
)
public_updated_at = grouped[0][:metadata][:public_updated_at]
@@ -143,7 +131,7 @@ class GroupWithMissingDocument < TestCase
.select { |g| g["title"] == "One document missing from links" }
.first
- presented_links = presenter.group_document_links(group_with_missing_document, 0)
+ presented_links = presenter.group_document_links(group_with_missing_document)
presented_links_base_paths = presented_links.collect { |link| link[:link][:path] }
assert_equal(
diff --git a/test/presenters/travel_advice_presenter_test.rb b/test/presenters/travel_advice_presenter_test.rb
index 49a33e77c..c694e1543 100644
--- a/test/presenters/travel_advice_presenter_test.rb
+++ b/test/presenters/travel_advice_presenter_test.rb
@@ -82,30 +82,6 @@ def schema_name
assert_equal "Summary", first_nav_item
end
- test "navigation items are presented as trackable links unless they are the current part" do
- example = schema_item("full-country")
- current_part = example["details"]["parts"][1]
-
- first_part_presented = presented_item("full-country", current_part["slug"])
- navigation_items = first_part_presented.parts_navigation
-
- first_part_nav_item = navigation_items[0][0]
- current_part_nav_item = navigation_items[0][1]
- another_part_nav_item = navigation_items[0][2]
-
- assert_equal first_part_nav_item,
- "
Summary"
- assert_equal current_part_nav_item, current_part["title"]
- assert_equal another_part_nav_item,
- "
Terrorism"
- end
-
test "navigation items link to all parts" do
parts = schema_item("full-country")["details"]["parts"]
part_links = presented_item("full-country").parts_navigation.flatten
diff --git a/test/test_helper.rb b/test/test_helper.rb
index 64e0938d1..8bffc5940 100644
--- a/test/test_helper.rb
+++ b/test/test_helper.rb
@@ -272,7 +272,7 @@ def find_structured_data(page, schema_name)
schemas.detect { |schema| schema["@type"] == schema_name }
end
- def single_page_notification_button_ga_tracking(index_link, section)
+ def single_page_notification_button_ga4_tracking(index_link, section)
{
"event_name" => "navigation",
"type" => "subscribe",