From b027e8a4fa2307ac407869376d949aaec1f6232b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 28 Jun 2024 13:27:13 +0000 Subject: [PATCH 1/2] Bump govuk_schemas from 5.0.2 to 5.0.4 Bumps [govuk_schemas](https://github.com/alphagov/govuk_schemas_gem) from 5.0.2 to 5.0.4. - [Changelog](https://github.com/alphagov/govuk_schemas/blob/main/CHANGELOG.md) - [Commits](https://github.com/alphagov/govuk_schemas_gem/compare/v5.0.2...v5.0.4) --- updated-dependencies: - dependency-name: govuk_schemas dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 191ac7f59..10ad8dc94 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -171,7 +171,8 @@ GEM rouge sprockets (>= 3) sprockets-rails - govuk_schemas (5.0.2) + govuk_schemas (5.0.4) + faker (~> 3.4.1) json-schema (>= 2.8, < 4.4) govuk_test (4.1.0) brakeman (>= 5.0.2) From 2e17817ab4e68c845ce847a79343adf5256e71bf Mon Sep 17 00:00:00 2001 From: Mateusz Grotek Date: Fri, 28 Jun 2024 16:21:23 +0100 Subject: [PATCH 2/2] Remove unnecessary tests for service_sign_in --- .../service_sign_in/choose_sign_in_test.rb | 10 ---------- .../service_sign_in/create_new_account_test.rb | 15 --------------- 2 files changed, 25 deletions(-) diff --git a/test/integration/service_sign_in/choose_sign_in_test.rb b/test/integration/service_sign_in/choose_sign_in_test.rb index d92a3563a..15b62380b 100644 --- a/test/integration/service_sign_in/choose_sign_in_test.rb +++ b/test/integration/service_sign_in/choose_sign_in_test.rb @@ -2,16 +2,6 @@ module ServiceSignIn class ChooseSignInTest < ActionDispatch::IntegrationTest - test "random but valid items do not error" do - payload = GovukSchemas::RandomExample.for_schema(frontend_schema: schema_type) - path = payload["details"]["choose_sign_in"]["slug"] - - stub_request(:get, %r{#{path}}) - .to_return(status: 200, body: payload.to_json, headers: {}) - - visit path - end - test "page renders correctly" do setup_and_visit_choose_sign_in_page("service_sign_in", "/choose-sign-in") diff --git a/test/integration/service_sign_in/create_new_account_test.rb b/test/integration/service_sign_in/create_new_account_test.rb index d84da637a..42ce4e672 100644 --- a/test/integration/service_sign_in/create_new_account_test.rb +++ b/test/integration/service_sign_in/create_new_account_test.rb @@ -2,21 +2,6 @@ module ServiceSignIn class CreateNewAccount < ActionDispatch::IntegrationTest - test "random but valid items do not error" do - # Create new account is an optional field, so we need to try a few times to - # get an example with it present. - path = nil - until path - payload = GovukSchemas::RandomExample.for_schema(frontend_schema: schema_type) - path = payload.dig("details", "create_new_account", "slug") - end - - stub_request(:get, %r{#{path}}) - .to_return(status: 200, body: payload.to_json, headers: {}) - - visit path - end - test "page renders correctly" do setup_and_visit_create_new_account_page