From 6bb1f20ff9cf42c6e893d8a678cc98bb13a9fb74 Mon Sep 17 00:00:00 2001 From: Mat Moore Date: Wed, 11 Apr 2018 14:21:13 +0100 Subject: [PATCH] Move content id meta tag This is now part of the analytics component https://github.com/alphagov/static/pull/1375 I've removed the test for this because frontend components are faked when running the tests. --- app/views/layouts/application.html.erb | 1 - test/integration/content_item_test.rb | 28 -------------------------- test/test_helper.rb | 4 ---- 3 files changed, 33 deletions(-) delete mode 100644 test/integration/content_item_test.rb diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index c414c46d6..c33ae2af7 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -23,7 +23,6 @@ <% if @content_item.description %> <% end %> - <%= contextual_comms_test_variant.analytics_meta_tag.html_safe if whitelisted_campaign_page? %> <%= yield :extra_head_content %> diff --git a/test/integration/content_item_test.rb b/test/integration/content_item_test.rb deleted file mode 100644 index 2bb37bd27..000000000 --- a/test/integration/content_item_test.rb +++ /dev/null @@ -1,28 +0,0 @@ -require 'test_helper' - -class ContentItemTest < ActionDispatch::IntegrationTest - def test_examples - schema_types = %w( case_study coming_soon detailed_guide document_collection - fatality_notice gone html_publication publication statistics_announcement - take_part topical_event_about_page unpublishing working_group ) - - result = schema_types.inject({}) do |examples, schema_type| - examples[schema_type] = schema_type - examples - end - result["html_publication"] = "arabic_translation" - result["statistics_announcement"] = "cancelled_official_statistics" - result["working_group"] = "long" - result - end - - test "content id" do - test_examples.each do |schema_type, example| - define_singleton_method("schema_type") { schema_type } - - setup_and_visit_content_item(example) - has_component_metadata("name", "govuk:content-id") - has_component_metadata("content", @content_item["content_id"]) - end - end -end diff --git a/test/test_helper.rb b/test/test_helper.rb index 47287a57a..db25e0c8f 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -176,10 +176,6 @@ def assert_footer_has_published_dates(published = nil, last_updated = nil, histo assert_has_published_dates(published, last_updated, history_link, 1) end - def has_component_metadata(key, value) - assert page.has_css? "meta[#{key}=\"#{value}\"]", visible: false - end - def setup_and_visit_content_item(name, parameter_string = '') @content_item = get_content_example(name).tap do |item| content_store_has_item(item["base_path"], item.to_json)