Skip to content

Commit

Permalink
Remove CSS override for component
Browse files Browse the repository at this point in the history
We were overriding the CSS for the heading component. It's bad practice to do this, we should instead make use of the parameters which can be passed into the component.

This will make the headings render as 19px on desktop and 16px on mobile (as opposed to 16px on all devices).
  • Loading branch information
Vanita Barrett committed Aug 3, 2018
1 parent 5375d88 commit 4dcd4e6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
4 changes: 0 additions & 4 deletions app/assets/stylesheets/helpers/_taxonomy-navigation.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@
width: (1 / 3) * 100%;
padding: ($gutter-one-third / 2) ($gutter-half + $gutter-one-third) ($gutter-half + $gutter-one-third) 0;
}

.gem-c-heading {
@include bold-16;
}
}

.taxonomy-navigation__list-item {
Expand Down
6 changes: 4 additions & 2 deletions app/views/shared/_taxonomy_navigation.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
<div class="taxonomy-navigation__column">
<%= render "govuk_publishing_components/components/heading",
text: 'Topics',
heading_level: 2 %>
heading_level: 2,
font_size: 19 %>
<ul>
<% tagged_taxons.each do |tagged_taxon| %>
<li class="taxonomy-navigation__list-item">
Expand All @@ -18,7 +19,8 @@
<div class="taxonomy-navigation__column">
<%= render "govuk_publishing_components/components/heading",
text: 'Collections',
heading_level: 2 %>
heading_level: 2,
font_size: 19 %>
<ul>
<% related_collections.each do |base_path, title| %>
<li class="taxonomy-navigation__list-item">
Expand Down

0 comments on commit 4dcd4e6

Please sign in to comment.