Skip to content

Commit 4dcd4e6

Browse files
author
Vanita Barrett
committed
Remove CSS override for component
We were overriding the CSS for the heading component. It's bad practice to do this, we should instead make use of the parameters which can be passed into the component. This will make the headings render as 19px on desktop and 16px on mobile (as opposed to 16px on all devices).
1 parent 5375d88 commit 4dcd4e6

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

app/assets/stylesheets/helpers/_taxonomy-navigation.scss

-4
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@
3030
width: (1 / 3) * 100%;
3131
padding: ($gutter-one-third / 2) ($gutter-half + $gutter-one-third) ($gutter-half + $gutter-one-third) 0;
3232
}
33-
34-
.gem-c-heading {
35-
@include bold-16;
36-
}
3733
}
3834

3935
.taxonomy-navigation__list-item {

app/views/shared/_taxonomy_navigation.html.erb

+4-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
<div class="taxonomy-navigation__column">
55
<%= render "govuk_publishing_components/components/heading",
66
text: 'Topics',
7-
heading_level: 2 %>
7+
heading_level: 2,
8+
font_size: 19 %>
89
<ul>
910
<% tagged_taxons.each do |tagged_taxon| %>
1011
<li class="taxonomy-navigation__list-item">
@@ -18,7 +19,8 @@
1819
<div class="taxonomy-navigation__column">
1920
<%= render "govuk_publishing_components/components/heading",
2021
text: 'Collections',
21-
heading_level: 2 %>
22+
heading_level: 2,
23+
font_size: 19 %>
2224
<ul>
2325
<% related_collections.each do |base_path, title| %>
2426
<li class="taxonomy-navigation__list-item">

0 commit comments

Comments
 (0)