From 5ef73b6a1d841d34a50e4cd300f076e5ee094952 Mon Sep 17 00:00:00 2001
From: Alex J <alexandru.jurubita@digital.cabinet-office.gov.uk>
Date: Thu, 3 Mar 2022 17:07:29 +0000
Subject: [PATCH] Reset `<dl>` styles in important-metadata component

This component was probably relying on a reset stylesheet that has been removed and now adds the browser default margins to the dl and dd elements. We reset those values in the component stylesheet.
---
 app/assets/stylesheets/components/_important-metadata.scss | 5 +++++
 app/views/components/_important-metadata.html.erb          | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/app/assets/stylesheets/components/_important-metadata.scss b/app/assets/stylesheets/components/_important-metadata.scss
index 512fb5a40..91c0e0f95 100644
--- a/app/assets/stylesheets/components/_important-metadata.scss
+++ b/app/assets/stylesheets/components/_important-metadata.scss
@@ -21,11 +21,16 @@
   margin-bottom: 5px;
 }
 
+.app-c-important-metadata__list {
+  margin: 0;
+}
+
 .app-c-important-metadata__term {
   float: left;
   padding-right: govuk-spacing(1);
 }
 
 .app-c-important-metadata__definition {
+  margin: 0;
   font-weight: bold;
 }
diff --git a/app/views/components/_important-metadata.html.erb b/app/views/components/_important-metadata.html.erb
index ca50428ba..666f64972 100644
--- a/app/views/components/_important-metadata.html.erb
+++ b/app/views/components/_important-metadata.html.erb
@@ -10,7 +10,7 @@
     <% if title %>
       <h2 class="app-c-important-metadata__title"><%= sanitize title %></h2>
     <% end %>
-    <dl data-module="gem-track-click">
+    <dl class="app-c-important-metadata__list" data-module="gem-track-click">
     <% items.each do |title, definition| %>
       <dt class="app-c-important-metadata__term"><%= sanitize title.to_s %>: </dt>
       <dd class="app-c-important-metadata__definition"><%= sanitize definition %></dd>