Manually fix remaining linting issues

Author: Ben Thorner

app/presenters/content_item/metadata.rb

@@ -23,7 +23,7 @@ def publisher_metadata
       {
         published: published,
         last_updated: updated,
-        link_to_history: !!updated,
+        link_to_history: updated.present?,
         other: {
           from: from,
         },

app/presenters/content_item/parts.rb

@@ -16,7 +16,7 @@ def requesting_a_part?
     end
 
     def has_valid_part?
-      !!current_part && current_part != parts.first
+      current_part && current_part != parts.first
     end
 
     def current_part_title

app/presenters/content_item/updatable.rb

@@ -35,7 +35,7 @@ def change_history
       end
     end
 
-    # The direction of change history isn’t guaranteed
+    # The direction of change history isn't guaranteed
     # https://github.com/alphagov/govuk-content-schemas/issues/545
     def reverse_chronological_change_history
       change_history.sort_by { |item| Time.zone.parse(item[:timestamp]) }.reverse

app/presenters/specialist_document_presenter.rb

@@ -214,7 +214,7 @@ def any_updates?
   # Example:
   # https://www.gov.uk/aaib-reports/lockheed-l1011-385-1-15-g-bhbr-19-december-1989
   def bulk_published?
-    !!facet_values["bulk_published"]
+    facet_values["bulk_published"].present?
   end
 
   def statutory_instrument?

app/presenters/travel_advice_presenter.rb

@@ -123,7 +123,7 @@ def change_description
   # This led to users appending (in a variety of formats)
   # "Latest update:" to the start of the change description. The frontend now
   # has a latest update label, so we can strip this out.
-  # Avoids: "Latest update: Latest update - …"
+  # Avoids: "Latest update: Latest update - ..."
   def latest_update
     change_description.sub(/^Latest update:?\s-?\s?/i, "").tap do |latest|
       latest[0] = latest[0].capitalize if latest.present?

test/integration/consultation_test.rb

@@ -56,7 +56,7 @@ class ConsultationTest < ActionDispatch::IntegrationTest
 
     assert page.has_text?("Consultation")
 
-    # There’s no daylight savings after 2037
+    # There's no daylight savings after 2037
     # http://timezonesjl.readthedocs.io/en/stable/faq/#far-future-zoneddatetime-with-variabletimezone
     assert page.has_css?(".gem-c-notice", text: "This consultation opens at 1pm on 5 October 2200")
     assert page.has_text?(:all, "It closes at 4pm on 31 October 2210")