From 2e33d84473ab2a32292e8d0d648ab47f36ab1a69 Mon Sep 17 00:00:00 2001
From: Chris Banks <chris.banks@digital.cabinet-office.gov.uk>
Date: Mon, 3 Oct 2022 16:43:59 +0100
Subject: [PATCH] Remove unnecessary `mkdir /app` from Dockerfile.

---
 Dockerfile | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index e80f0ada3..33788b286 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,23 +1,20 @@
 ARG base_image=ghcr.io/alphagov/govuk-ruby-base:2.7.6
 ARG builder_image=ghcr.io/alphagov/govuk-ruby-builder:2.7.6
- 
-FROM $builder_image AS builder
 
-RUN mkdir /app
+FROM $builder_image AS builder
 
 WORKDIR /app
 
-COPY Gemfile* .ruby-version /app/
-
+COPY Gemfile* .ruby-version ./
 RUN bundle install
 
 COPY . /app
-# TODO: We probably don't want assets in the image; remove this once we have a proper deployment process which uploads to (e.g.) S3.
 RUN bundle exec rails assets:precompile && rm -rf /app/log
 
 
 FROM $base_image
 
+# TODO: remove PORT and set it in publishing-e2e-tests instead.
 ENV GOVUK_APP_NAME=government-frontend PORT=3090
 
 COPY --from=builder /usr/local/bundle/ /usr/local/bundle/