Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last list anchors broken on mobile / tablet viewport #99

Closed
Nooshu opened this issue Nov 20, 2017 · 3 comments
Closed

Last list anchors broken on mobile / tablet viewport #99

Nooshu opened this issue Nov 20, 2017 · 3 comments

Comments

@Nooshu
Copy link

Nooshu commented Nov 20, 2017

To reproduce:

margin-issue

Issue caused here

h3, h4, h5, h6 {
    @include heading-offset($gutter);
  }

Proposed fix:

  1. Either remove usage of the mixin in this case and add specific styling manually (less padding, no negative margin)
  2. Continue to use the mixin but add an override after it's usage

Option 1 seems like the cleanest to me with minimal impact.

@philandstuff
Copy link
Contributor

Thanks for the detailed error report! I've seen something similar before but it's good to see an analysis of the problem, its causes, and ways to fix it. We've added this to our backlog to take a look at it.

@Nooshu
Copy link
Author

Nooshu commented Nov 20, 2017

No problem @philandstuff. PR for option 1 here if the team are happy with the fix. If not just throw it away :)

@Nooshu
Copy link
Author

Nooshu commented Nov 23, 2017

Closing issue as it has been duplicated here.

@Nooshu Nooshu closed this as completed Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants