From 729503692f8172bfd9c535952fc5c25973cda159 Mon Sep 17 00:00:00 2001 From: Daniel Tan Date: Fri, 2 Apr 2021 13:24:03 +0800 Subject: [PATCH 1/2] (fix) fix AttributeError MSVCCompiler when building Windows binary --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 8a0c12f2d2..52c241a0bb 100755 --- a/setup.py +++ b/setup.py @@ -176,7 +176,7 @@ def main(): "bin/hummingbot.py", "bin/hummingbot_quickstart.py" ], - cmdclass={'build_ext': BuildExt}, + cmdclass={'build_ext': BuildExt} if os.name != "nt" else {}, ) From 3e371c2bfb4854588351ac69af38128cbb9ad28d Mon Sep 17 00:00:00 2001 From: Daniel Tan Date: Fri, 2 Apr 2021 13:49:36 +0800 Subject: [PATCH 2/2] (cleanup) cleanup fix as per Patrick feedback --- setup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index 52c241a0bb..fc70445f2d 100755 --- a/setup.py +++ b/setup.py @@ -23,7 +23,7 @@ # for C/ObjC but not for C++ class BuildExt(build_ext): def build_extensions(self): - if '-Wstrict-prototypes' in self.compiler.compiler_so: + if os.name != "nt" and '-Wstrict-prototypes' in self.compiler.compiler_so: self.compiler.compiler_so.remove('-Wstrict-prototypes') super().build_extensions() @@ -176,7 +176,7 @@ def main(): "bin/hummingbot.py", "bin/hummingbot_quickstart.py" ], - cmdclass={'build_ext': BuildExt} if os.name != "nt" else {}, + cmdclass={'build_ext': BuildExt}, )