Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playwright step statuses and tests structure #1244

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix playwright step statuses and tests structure #1244

wants to merge 3 commits into from

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented Feb 4, 2025

Context

fixes #1240

Checklist

@github-actions github-actions bot added theme:api Javascript API related issue theme:playwright labels Feb 4, 2025
@epszaw epszaw added type:bug Something isn't working and removed theme:api Javascript API related issue labels Feb 4, 2025
baev
baev requested changes Feb 4, 2025
View reviewed changes
packages/allure-playwright/vitest.config.ts Outdated Show resolved Hide resolved
@epszaw epszaw force-pushed the fix-pw-tests-structure branch from ee24e8a to 2fbc8db Compare February 4, 2025 17:17
@github-actions github-actions bot added the theme:api Javascript API related issue label Feb 4, 2025
@epszaw epszaw changed the title Fix playwright step statuses and metadata attachments Fix playwright step statuses and tests structure Feb 4, 2025
@epszaw epszaw requested a review from baev February 7, 2025 15:54
epszaw added 3 commits February 7, 2025 17:13
@epszaw
fix problem when parent step markes as passed, but contains failed child
a6a31b1
@epszaw
add shallow stack class
cec96d3 
fix problem with incorrect before/after hooks reporting in playwright
@epszaw
add method to update shallow stack's steps
b5504ab 
change stop method signature
complete new hooks reporting logic for pw
fix failed pw tests
@epszaw epszaw force-pushed the fix-pw-tests-structure branch from 5b23887 to b5504ab Compare February 7, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev Awaiting requested review from baev

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
theme:api Javascript API related issue theme:playwright type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metadata is missing on update from 2.15.1 to 3.1.0
2 participants
@epszaw @baev