Skip to content

cstrike: Fix wrong timeleft calculation #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2019
Merged

cstrike: Fix wrong timeleft calculation #1072

merged 2 commits into from
Sep 2, 2019

Conversation

@BotoX
Copy link
Contributor

@BotoX BotoX commented Sep 2, 2019

(I actually forgot what exactly the buggy behavior was)

@BotoX
Copy link
Contributor Author

BotoX commented Sep 2, 2019

[8:18 PM] Moltard: "cstrike: Fix wrong timeleft calculation"
wasnt it that the timeleft from the scoreboard and the sourcemod timeleft were different, and the vote happened on the sourcemod timeleft. but final round happened on the scoreboard timeleft
[8:19 PM] Moltard: the difference between the 2 happened after doing a mp_restartgame 1 in maps
[8:24 PM] zaCade: ye
[8:24 PM] zaCade: that was it
[8:25 PM] zaCade: The time in sourcemod wouldnt reset
[8:25 PM] zaCade: while the scoreboard ect would
[8:25 PM] Moltard: and if the difference was too big, the map could end with no nextmap and it was a random nextmap picked
[8:25 PM] zaCade: yep
[8:25 PM] Moltard: nah I think ti's the opposite
[8:25 PM] Moltard: the scoreboard time didnt reset
[8:25 PM] Moltard: but sourcemod reset
[8:25 PM] zaCade: no it does
[8:25 PM] Moltard: on mg it happened so many time
[8:26 PM] Moltard: (or on mg, that was different)
[8:26 PM] zaCade: That was something else

KyleSanderson
KyleSanderson requested changes Sep 2, 2019
View reviewed changes
Copy link
Member

@KyleSanderson KyleSanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor - the problem case has definitely happened to us before.

extensions/cstrike/timeleft.cpp Outdated

float flGameStartTime = gpGlobals->curtime;
sm_sendprop_info_t info;
if (gamehelpers->FindSendPropInfo("CCSGameRulesProxy", "m_flGameStartTime", &info))
Copy link
Member

@KyleSanderson KyleSanderson Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you nest this under gamerules? Doesn't make sense to do the lookup if the variable is only used if gamerules is valid. Not that this is a hot path - just a nit.

KyleSanderson
KyleSanderson approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@KyleSanderson KyleSanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thx bud.

@KyleSanderson KyleSanderson merged commit d93f698 into alliedmodders:master Sep 2, 2019
BotoX added a commit to BotoX/sourcemod that referenced this pull request Sep 10, 2019
@BotoX
cstrike: Fix wrong timeleft calculation (alliedmodders#1072)
552f79f 
* Fix wrong timeleft calculation

* reorder function calls
BotoX added a commit to BotoX/sourcemod that referenced this pull request Sep 21, 2019
@BotoX
cstrike: Fix wrong timeleft calculation (alliedmodders#1072)
8db2132 
* Fix wrong timeleft calculation

* reorder function calls
Headline pushed a commit that referenced this pull request Nov 1, 2019
@BotoX @Headline
cstrike: Fix wrong timeleft calculation (#1072)
6a0d99f 
* Fix wrong timeleft calculation

* reorder function calls
@Adrianilloo Adrianilloo mentioned this pull request Aug 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KyleSanderson KyleSanderson KyleSanderson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BotoX @KyleSanderson