matchHost() should only care about hosts

When `ignoreHostname` is set to true, any hostname comparison should
always return true. When it's disabled, it should compare hostnames
and hostnames only.

Co-authored-by: Jan Vernieuwe <[email protected]>

Closes #7

Author: allejo

src/RelaxedRequestMatcher.php

@@ -45,13 +45,11 @@ public static function matchQueryString(Request $first, Request $second)
 
     public static function matchHost(Request $first, Request $second)
     {
-        $firstURL = parse_url($first->getUrl());
-        $secondURL = parse_url($second->getUrl());
-
-        unset($firstURL['host']);
-        unset($secondURL['host']);
+        if (Config::ignoreReqHostname()) {
+            return true;
+        }
 
-        return $firstURL === $secondURL;
+        return $first->getHost() === $second->getHost();
     }
 
     public static function matchHeaders(Request $first, Request $second)

tests/VCR/RelaxedRequestMatcherTest.php

@@ -16,7 +16,7 @@
 
 class RelaxedRequestMatcherTest extends \PHPUnit_Framework_TestCase
 {
-    public function testRelaxedRequestMatcherQueryHost()
+    public function testRelaxedRequestMatcherQueryHostEnabled()
     {
         $actualRequest = new Request('GET', 'http://example.com/api/v1?query=users');
         $cleanRequest = new Request('GET', 'http://[]/api/v1?query=users');
@@ -27,10 +27,27 @@ public function testRelaxedRequestMatcherQueryHost()
             ),
         ));
 
+        $this->assertEquals('[]', $cleanRequest->getHost());
         $this->assertFalse(RequestMatcher::matchHost($actualRequest, $cleanRequest));
         $this->assertTrue(RelaxedRequestMatcher::matchHost($actualRequest, $cleanRequest));
     }
 
+    public function testRelaxedRequestMatcherQueryHostDisabled()
+    {
+        $actualRequest = new Request('GET', 'http://example.com/api/v1?query=users');
+        $cleanRequest = new Request('GET', 'http://[]/api/v1?query=users');
+
+        Config::configureOptions(array(
+            'request' => array(
+                'ignoreHostname' => false,
+            ),
+        ));
+
+        $this->assertEquals('[]', $cleanRequest->getHost());
+        $this->assertFalse(RequestMatcher::matchHost($actualRequest, $cleanRequest));
+        $this->assertFalse(RelaxedRequestMatcher::matchHost($actualRequest, $cleanRequest));
+    }
+
     public function testRelaxedRequestMatcherQueryString()
     {
         $actualRequest = new Request('GET', 'http://example.com/api/v1?query=users&apiKey=SomethingSensitive');