Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First bot PR changed our table layout #57

Closed
jerodsanto opened this issue Jan 17, 2019 · 5 comments
Closed

First bot PR changed our table layout #57

jerodsanto opened this issue Jan 17, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@jerodsanto
Copy link

(Thanks so much for building this!)

On first use with an existing contributors list (generated via the command-line tool), the bot sets contributorsPerLine to 7 in our config file. This is undesirable as the 7th column in each row is squished smaller than the others:

2019-01-17 at 8 40 am

PR here

@jerodsanto jerodsanto added the bug Something isn't working label Jan 17, 2019
@jakebolam
Copy link
Contributor

Hey @jerodsanto.

Thanks for reporting this! What should be the behaviour?

I took a look at the changelog/transcripts project README (on master) and it appears to be 7 across too. (The CLI has a default of 7, the bot explicit calls this out, you can configure this in your RC file and the bot will respect this).

To avoid confusion we could have the CLI explicitly set this setting too (for consistent behaviour)

screenshot_20190118-091911

@jerodsanto
Copy link
Author

lol that's embarrassing I didn't even notice until I saw the bot modify the rc file!

The behavior I'd expect is for the bot to not edit your config at all, but I'd be fine with the CLI also setting that explicitly by default.

@jakebolam
Copy link
Contributor

Yes I agree modifying is a little weird, adding code to not modify in certain cases adds weird complexity to the bot (I also think being explicit in the file is a good idea).

Do you think it would still be confusing even after? all-contributors/cli#149

@jerodsanto
Copy link
Author

I think that's Good Enough 👌

@jakebolam
Copy link
Contributor

Thanks @jerodsanto. Any other issues feel free to file. Want to make this really great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants