Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Pretty-print the generagted HTML table #190

Merged
merged 2 commits into from
Jun 11, 2019
Merged

feat: Pretty-print the generagted HTML table #190

merged 2 commits into from
Jun 11, 2019

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Jun 6, 2019

Closes #189
Keeps the Table left aligned, and moves the tr and td in by 2 spaces each

@nschonni
feat: Pretty-print the generagted HTML table
3a875aa 
Closes all-contributors#189
Keeps the Table left aligned, and moves the tr and td in by 2 spaces each
@jakebolam
Copy link
Collaborator

Thanks 🙏 @nschonni

@jakebolam
Copy link
Collaborator

@all-contributors please add @nschonni for code

@allcontributors allcontributors bot mentioned this pull request Jun 6, 2019
Merged
@allcontributors
Copy link
Contributor

@jakebolam

I've put up a pull request to add @nschonni! 🎉

Berkmann18
Berkmann18 approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Berkmann18 Berkmann18 merged commit 68166ec into all-contributors:master Jun 11, 2019
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nschonni nschonni deleted the pretty-print-table branch June 11, 2019 16:49
@nschonni nschonni mentioned this pull request Jun 11, 2019
Closed
@nschonni
Copy link
Contributor Author

Thanks @Berkmann18!
Is there a process for getting the bot updated too? Or does the lockfile there need to be manually updated https://github.com/all-contributors/all-contributors-bot/blob/master/yarn.lock

@Berkmann18
Copy link
Member

@nschonni It depends on the changes as some may only need to be done on the CLI for it to be used by the bot (I believe that's one of them) and others which would require some changes on the bot as well.

In the case of lock file updates, it would have to be done there as well.

@nschonni nschonni mentioned this pull request Jun 24, 2019
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebolam jakebolam jakebolam approved these changes

@Berkmann18 Berkmann18 Berkmann18 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pretty-print/Format the generated HTML table
4 participants
@nschonni @jakebolam @all-contributors-release-bot @Berkmann18