Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require path error #148

Merged
merged 1 commit into from
Jan 17, 2019
Merged

fix: require path error #148

merged 1 commit into from
Jan 17, 2019

Conversation

sinchang
Copy link
Contributor

@sinchang sinchang commented Jan 17, 2019 •
edited
Loading

What:

Why:
fix: require path error

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@sinchang sinchang requested a review from a team January 17, 2019 05:35
@sinchang sinchang mentioned this pull request Jan 17, 2019
Closed
jakebolam
jakebolam approved these changes Jan 17, 2019
View reviewed changes
Copy link
Collaborator

@jakebolam jakebolam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Weird this was fixed in #145

@sinchang sinchang merged commit 9bfdd72 into master Jan 17, 2019
@sinchang sinchang deleted the fix/5.10.0 branch January 17, 2019 06:28
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 5.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebolam jakebolam jakebolam approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinchang @all-contributors-release-bot @jakebolam