You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fyi this something I really wanna get rid of soon :D I mean the files should be all referenced as relative paths, and the parameter provided (the context.json or the suite.json) to the app should determine the "repositoryRoot"
so there would be no "local" here
and "queryPath" would be "volcziTest/queryToTest.sql" or "queryToTest.sql"
or even if we keep it the repositoryRoot should be relative, so instead of "C:\dev\jarvis" it would be "../../." etc
some modification, I would say that local option should be kept for the use-case when the references resources are at a totally different place in the folder tree and to avoid writing ../../../.. dozen times
BUT there should be a default - the same folder - so without a local context provided for example it would be "queryToTest.sql", but it could be configured to support something different as root
@nbali on contexts.json contextType:
fyi this something I really wanna get rid of soon :D I mean the files should be all referenced as relative paths, and the parameter provided (the context.json or the suite.json) to the app should determine the "repositoryRoot"
so there would be no "local" here
and "queryPath" would be "volcziTest/queryToTest.sql" or "queryToTest.sql"
or even if we keep it the repositoryRoot should be relative, so instead of "C:\dev\jarvis" it would be "../../." etc
my aim is to get rid of EVERY absolute path
(see https://github.com/aliz-ai/jarvis/tree/cleanup_before_trivago_intergation | https://reviewable.io/reviews/aliz-ai/jarvis/45/examples/sample_volczi/contexts.json#-)
The text was updated successfully, but these errors were encountered: