Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup the path in context #47

Open
gaborvolczer opened this issue Mar 16, 2022 · 2 comments
Open

cleanup the path in context #47

gaborvolczer opened this issue Mar 16, 2022 · 2 comments

Comments

@gaborvolczer
Copy link
Contributor

gaborvolczer commented Mar 16, 2022

@nbali on contexts.json contextType:

fyi this something I really wanna get rid of soon :D I mean the files should be all referenced as relative paths, and the parameter provided (the context.json or the suite.json) to the app should determine the "repositoryRoot"

so there would be no "local" here

and "queryPath" would be "volcziTest/queryToTest.sql" or "queryToTest.sql"

or even if we keep it the repositoryRoot should be relative, so instead of "C:\dev\jarvis" it would be "../../." etc

my aim is to get rid of EVERY absolute path

(see https://github.com/aliz-ai/jarvis/tree/cleanup_before_trivago_intergation | https://reviewable.io/reviews/aliz-ai/jarvis/45/examples/sample_volczi/contexts.json#-)

@nbali
Copy link
Contributor

nbali commented Apr 21, 2022

some modification, I would say that local option should be kept for the use-case when the references resources are at a totally different place in the folder tree and to avoid writing ../../../.. dozen times

BUT there should be a default - the same folder - so without a local context provided for example it would be "queryToTest.sql", but it could be configured to support something different as root

@nbali
Copy link
Contributor

nbali commented Apr 21, 2022

also it worth considering to move the repositoryRoot from a dedicated local context to the actual test suite json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants