Skip to content

Commit b3d0362

Browse files
authored
Merge pull request #191 from EvanLjp/fix-put-log-shard-hash
fix miss user hash key in hash sending when off AdjustShardHash
2 parents c5ff0aa + cf6e76a commit b3d0362

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

Diff for: producer/producer.go

+8-12
Original file line numberDiff line numberDiff line change
@@ -113,14 +113,13 @@ func (producer *Producer) HashSendLogWithCallBack(project, logstore, shardHash,
113113
if err != nil {
114114
return err
115115
}
116-
var newShardHash string
117116
if producer.producerConfig.AdjustShargHash {
118-
newShardHash, err = AdjustHash(shardHash, producer.buckets)
117+
shardHash, err = AdjustHash(shardHash, producer.buckets)
119118
if err != nil {
120119
return err
121120
}
122121
}
123-
return producer.logAccumulator.addLogToProducerBatch(project, logstore, newShardHash, topic, source, log, callback)
122+
return producer.logAccumulator.addLogToProducerBatch(project, logstore, shardHash, topic, source, log, callback)
124123
}
125124

126125
func (producer *Producer) HashSendLogListWithCallBack(project, logstore, shardHash, topic, source string, logList []*sls.Log, callback CallBack) (err error) {
@@ -129,14 +128,13 @@ func (producer *Producer) HashSendLogListWithCallBack(project, logstore, shardHa
129128
if err != nil {
130129
return err
131130
}
132-
var newShardHash string
133131
if producer.producerConfig.AdjustShargHash {
134-
newShardHash, err = AdjustHash(shardHash, producer.buckets)
132+
shardHash, err = AdjustHash(shardHash, producer.buckets)
135133
if err != nil {
136134
return err
137135
}
138136
}
139-
return producer.logAccumulator.addLogToProducerBatch(project, logstore, newShardHash, topic, source, logList, callback)
137+
return producer.logAccumulator.addLogToProducerBatch(project, logstore, shardHash, topic, source, logList, callback)
140138
}
141139

142140
func (producer *Producer) SendLog(project, logstore, topic, source string, log *sls.Log) error {
@@ -162,29 +160,27 @@ func (producer *Producer) HashSendLog(project, logstore, shardHash, topic, sourc
162160
if err != nil {
163161
return err
164162
}
165-
var newShardHash string
166163
if producer.producerConfig.AdjustShargHash {
167-
newShardHash, err = AdjustHash(shardHash, producer.buckets)
164+
shardHash, err = AdjustHash(shardHash, producer.buckets)
168165
if err != nil {
169166
return err
170167
}
171168
}
172-
return producer.logAccumulator.addLogToProducerBatch(project, logstore, newShardHash, topic, source, log, nil)
169+
return producer.logAccumulator.addLogToProducerBatch(project, logstore, shardHash, topic, source, log, nil)
173170
}
174171

175172
func (producer *Producer) HashSendLogList(project, logstore, shardHash, topic, source string, logList []*sls.Log) (err error) {
176173
err = producer.waitTime()
177174
if err != nil {
178175
return err
179176
}
180-
var newShardHash string
181177
if producer.producerConfig.AdjustShargHash {
182-
newShardHash, err = AdjustHash(shardHash, producer.buckets)
178+
shardHash, err = AdjustHash(shardHash, producer.buckets)
183179
if err != nil {
184180
return err
185181
}
186182
}
187-
return producer.logAccumulator.addLogToProducerBatch(project, logstore, newShardHash, topic, source, logList, nil)
183+
return producer.logAccumulator.addLogToProducerBatch(project, logstore, shardHash, topic, source, logList, nil)
188184

189185
}
190186

0 commit comments

Comments
 (0)