Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests that fail due to multiprocessing #196

Closed
alichtman opened this issue Nov 14, 2018 · 2 comments
Closed

Fix tests that fail due to multiprocessing #196

alichtman opened this issue Nov 14, 2018 · 2 comments
Assignees
@alichtman
Labels
devops testing

Comments

@alichtman
Copy link
Owner

alichtman commented Nov 14, 2018 •
edited
Loading

pytest-dev/pytest-cov#242

https://coveralls.io/github/alichtman/shallow-backup

Coverage Status
@alichtman alichtman changed the title Configure codeclimate for code coverage Configure pytest-cov for code coverage and link to coveralls.io Nov 16, 2018
@alichtman alichtman self-assigned this Nov 16, 2018
@alichtman alichtman changed the title Configure pytest-cov for code coverage and link to coveralls.io Fix tests that fail only with pytest-cov Nov 16, 2018
@alichtman
Copy link
Owner Author

alichtman commented Nov 18, 2018 •
edited
Loading

WOW DUDE, how did you miss this? The backup method needs to add some sort of barrier to make sure the multiprocessing finishes.

@alichtman alichtman changed the title Fix tests that fail only with pytest-cov Fix tests that fail due to multiprocessing Nov 18, 2018
@alichtman
Copy link
Owner Author

smfh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alichtman alichtman

Labels
devops testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alichtman