Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix open recent broken on windows and remove unnecessary warnings #940

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Fix open recent broken on windows and remove unnecessary warnings #940

merged 2 commits into from
Jun 20, 2020

Conversation

ChemicalXandco
Copy link
Contributor

Features list

@ChemicalXandco
Copy link
Contributor Author

ChemicalXandco commented Jun 19, 2020 •
edited
Loading

The windows path problem was fixed in 0e43490, but there is no sign of if it will be merged any time soon

@fabiencastan
Copy link
Member

Thanks for these fixes! I didn't have time to test yet.
It will be merged soon.

@fabiencastan fabiencastan added this to the Meshroom 2020.1.0 milestone Jun 19, 2020
@fabiencastan fabiencastan merged commit 9ccc726 into alicevision:develop Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

Assignees
No one assigned
Labels
bugfix windows
Projects
None yet
Milestone
Meshroom 2020.1.0
Development

Successfully merging this pull request may close these issues.

Open Recent is broken on Windows (wrong path separator?)
3 participants
@ChemicalXandco @fabiencastan @simogasp