fix python nodes being blocked by log #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...when ran on command line with meshroom_photogrammetry or meshroom_compute
setup.py
Outdated
| @@ -41,6 +41,8 @@ def __init__(self, script, initScript=None, base=None, targetName=None, icons=No | |||
| build_exe_options = { | |||
| # include dynamically loaded plugins | |||
| "packages": ["meshroom.nodes", "meshroom.submitters"], | |||
| # cx_Freeze does not copy idnadata by default, so it needs to be added here | |||
There was a problem hiding this comment.
"includes": [
"idna.idnadata", # Dependency needed by SketchfabUpload node, but not detected by cx_Freeze
],
| if not chunk.node.output.value: | ||
| return | ||
| try: | ||
| chunk.logManager.start(chunk.node.verboseLevel.value) |
There was a problem hiding this comment.
Would be nice to use with instead of start/end:
with chunk.logManager:
...
fabiencastan
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #780, the log is cleared directly from
processChunkinstead of relying on chunk.statusChanged