Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph editor improvements #349

Merged
merged 9 commits into from
Jan 11, 2019
Merged

Conversation

yann-lty
Copy link
Member

@yann-lty yann-lty commented Jan 9, 2019

This PR contains various improvements in the Graph Editor module.

  • consistent read-only mode when computing, that can be unlocked in advanced settings
  • Improved Node Menu: "duplicate"/"remove"/"delete data" with "From Here" accessible on the same entry via an additional button
  • confirmation popup before deleting node data
  • add "Clear Pending Status" action at Graph level
  • solo media in 3D viewer with Ctrl+ double click on node/attribute

* ease the deletion of a branch from a given starting point
* accessible with alt+del on a node
* re-order menu to put the most destructive operation (Clear Data) at the very end
* add a ToolButton for duplicating/removing following nodes in corresponding entries instead of having a separate item
* change text when those button are hovered to reflect the change of action
* wording: rename "Delete Node" to "Remove Node"
* allow to clear status of all submitted nodes in the graph
* unify wording
* lock edit actions when graph is being computed
* add an advanced option to control this behavior and unlock it (stored in persistent settings)
* allow to solo a 3D media from the GraphEditor by double clicking on a node or an attribute with the Control modifier pressed
* consistent with Viewer3D.MediaLibrary behavior (solo on Ctrl+Click on visibility button)
* handle supported file extensions in Viewer3DSettings
* use it in MetadataListView and GraphEditor 'add Node' menu
* GraphEditor: forward MenuItem key events to searchBar to be able to continue editing the filter even if it lost active focus
@fabiencastan fabiencastan merged commit 0de3e49 into develop Jan 11, 2019
@fabiencastan fabiencastan deleted the dev_graphEditor_improvements branch January 11, 2019 21:41
@natowi natowi mentioned this pull request Jan 15, 2019
15 tasks
@fabiencastan fabiencastan added this to the Meshroom 2019.1.0 milestone Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants