Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Cannot save the SfM data file The file extension is not recognized. #890

Closed
skinkie opened this issue May 10, 2020 · 6 comments · Fixed by alicevision/AliceVision#878
Labels
do not close issue that should stay open (avoid automatically close because stale) type:question

Comments

@skinkie
Copy link

skinkie commented May 10, 2020

Describe the problem
I am running the basic pipeline. Within the Structure From Motion step I observe that the files cannot be saved.

Log
[21:57:05.808979][info] Structure from motion took (s): 199.757000
[21:57:05.809136][info] Generating HTML report...
[21:57:05.883260][info] Export SfMData to disk: /home/skinkie/meshroom/MeshroomCache/StructureFromMotion/a884ca809714e827b0707bbf27d3881297458742/sfm.abc
[21:57:05.883387][error] Cannot save the SfM data file: '/home/skinkie/meshroom/MeshroomCache/StructureFromMotion/a884ca809714e827b0707bbf27d3881297458742/cloud_and_poses.abc'.
The file extension is not recognized.
[21:57:05.883455][error] Cannot save the SfM data file: '/home/skinkie/meshroom/MeshroomCache/StructureFromMotion/a884ca809714e827b0707bbf27d3881297458742/sfm.abc'.
The file extension is not recognized.
[21:57:05.962271][info] Structure from Motion results:
- # input images: 164
- # cameras calibrated: 146
- # poses: 146
- # landmarks: 53943

Desktop (please complete the following and other pertinent information):

  • OS: Linux
  • Python Python 3.6.10
  • Qt/PySide version 5.14.2
  • Meshroom version:
    • Commit reference (if applicable) 1e58895
    • AliceVision commit 30fe982 (latest develop)
@skinkie
Copy link
Author

skinkie commented May 10, 2020

I think that we can prevent this question if this could be revamped to a: Alembic is not compiled in.

#if ALICEVISION_IS_DEFINED(ALICEVISION_HAVE_ALEMBIC)
  else if(extension == ".abc") // Alembic
  {
    AlembicImporter(filename).populateSfM(sfmData, partFlag);
    status = true;
  }
#endif // ALICEVISION_HAVE_ALEMBIC

@simogasp
Copy link
Member

@fabiencastan is there a way to make mushroom aware of the build conf of AV and e.g, avoid using alembic?

@fabiencastan
Copy link
Member

@skinkie yes, you need to build AV with Alembic.

@simogasp No, the extension is abc in many places and is not exposed as an option.
We should maybe switch the ALICEVISION_USE_ALEMBIC from AUTO to ON. So by default, ensure people build with Alembic and they can explicitly disable the dependency if they don't need it.

@skinkie
Copy link
Author

skinkie commented May 11, 2020

@skinkie yes, you need to build AV with Alembic.

Yes, if only I knew what went wrong because I didn't do it. Would a slight change in AliceVision be acceptable where the #ifdev would explicitly return in an error when loading/saving a file?

@simogasp No, the extension is abc in many places and is not exposed as an option.
We should maybe switch the ALICEVISION_USE_ALEMBIC from AUTO to ON. So by default, ensure people build with Alembic and they can explicitly disable the dependency if they don't need it.

It seems that the code does not fall back to building the dependency if the system does not have it. I hope with ON this can be guaranteed.

@fabiencastan
Copy link
Member

Oh, you're right. I didn't pay attention to the code!
We should probably do something like:

  else if(extension == ".abc") // Alembic
  {
#if ALICEVISION_IS_DEFINED(ALICEVISION_HAVE_ALEMBIC)
    AlembicImporter(filename).populateSfM(sfmData, partFlag);
    status = true;
#else
   ALICEVISION_THROW_ERROR("Cannot load the ABC file: \""<< filename <<"\", AliceVision is built without Alembic support.");
#endif // ALICEVISION_HAVE_ALEMBIC
  }

@stale stale bot added the stale for issues that becomes stale (no solution) label Sep 8, 2020
@skinkie
Copy link
Author

skinkie commented Sep 8, 2020

Keep open.

@alicevision alicevision deleted a comment from stale bot Sep 8, 2020
@stale stale bot removed the stale for issues that becomes stale (no solution) label Sep 8, 2020
@fabiencastan fabiencastan added the do not close issue that should stay open (avoid automatically close because stale) label Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not close issue that should stay open (avoid automatically close because stale) type:question
Projects
None yet
3 participants