From ae05bd7bafc2e8e863205139acaa2bdab21d6886 Mon Sep 17 00:00:00 2001 From: fabien servant Date: Tue, 11 Aug 2020 07:56:01 +0200 Subject: [PATCH 1/4] add a choice for graphcut use --- meshroom/nodes/aliceVision/PanoramaCompositing.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/meshroom/nodes/aliceVision/PanoramaCompositing.py b/meshroom/nodes/aliceVision/PanoramaCompositing.py index 5b34fc247a..ff08d3a546 100644 --- a/meshroom/nodes/aliceVision/PanoramaCompositing.py +++ b/meshroom/nodes/aliceVision/PanoramaCompositing.py @@ -54,6 +54,13 @@ class PanoramaCompositing(desc.CommandLineNode): exclusive=True, uid=[0] ), + desc.BoolParam( + name='useGraphCut', + label='Use smart seams', + description='Use a graphcut algorithm to select the seams for better compositing', + value=True, + uid=[0], + ), desc.ChoiceParam( name='overlayType', label='Overlay Type', From 73597e93526d345d70e563277ce85e99ccb67f24 Mon Sep 17 00:00:00 2001 From: Fabien Castan Date: Thu, 3 Sep 2020 12:26:19 +0200 Subject: [PATCH 2/4] [nodes] PanoramaCompositing: add "all" option to "overlayType" choice param --- meshroom/nodes/aliceVision/PanoramaCompositing.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/meshroom/nodes/aliceVision/PanoramaCompositing.py b/meshroom/nodes/aliceVision/PanoramaCompositing.py index ff08d3a546..40bbbac496 100644 --- a/meshroom/nodes/aliceVision/PanoramaCompositing.py +++ b/meshroom/nodes/aliceVision/PanoramaCompositing.py @@ -67,9 +67,10 @@ class PanoramaCompositing(desc.CommandLineNode): description='Overlay on top of panorama to analyze transitions:\n' ' * none: no overlay\n' ' * borders: display image borders\n' - ' * seams: display transitions between images\n', + ' * seams: display transitions between images\n' + ' * all: display borders and seams\n', value='none', - values=['none', 'borders', 'seams'], + values=['none', 'borders', 'seams', 'all'], exclusive=True, advanced=True, uid=[0] From d1ab87234df4a37347fc201b5a6560978c6bbb68 Mon Sep 17 00:00:00 2001 From: Fabien Castan Date: Fri, 4 Sep 2020 16:59:08 +0200 Subject: [PATCH 3/4] [nodes] PanoramaCompositing: minor wording change --- meshroom/nodes/aliceVision/PanoramaCompositing.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meshroom/nodes/aliceVision/PanoramaCompositing.py b/meshroom/nodes/aliceVision/PanoramaCompositing.py index 40bbbac496..02368542e4 100644 --- a/meshroom/nodes/aliceVision/PanoramaCompositing.py +++ b/meshroom/nodes/aliceVision/PanoramaCompositing.py @@ -56,8 +56,8 @@ class PanoramaCompositing(desc.CommandLineNode): ), desc.BoolParam( name='useGraphCut', - label='Use smart seams', - description='Use a graphcut algorithm to select the seams for better compositing', + label='Use Smart Seams', + description='Use a graphcut algorithm to optmize seams for better transitions between images.', value=True, uid=[0], ), From 11af1cca69839969eed10abde52a0bcc6b2f4a20 Mon Sep 17 00:00:00 2001 From: Fabien Castan Date: Fri, 4 Sep 2020 16:59:46 +0200 Subject: [PATCH 4/4] [nodes] ImageProcessing: minor wording change --- meshroom/nodes/aliceVision/ImageProcessing.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meshroom/nodes/aliceVision/ImageProcessing.py b/meshroom/nodes/aliceVision/ImageProcessing.py index f97c8ab4c3..6ae880e9bc 100644 --- a/meshroom/nodes/aliceVision/ImageProcessing.py +++ b/meshroom/nodes/aliceVision/ImageProcessing.py @@ -119,8 +119,8 @@ class ImageProcessing(desc.CommandLineNode): ), desc.BoolParam( name='fillHoles', - label='Fill holes', - description='Fill holes.', + label='Fill Holes', + description='Fill holes based on the alpha channel.', value=False, uid=[0], ),