refine

Author: louyuting

core/stat/base/bucket_leap_array.go

@@ -29,7 +29,8 @@ func (bla *BucketLeapArray) ResetBucketTo(bw *BucketWrap, startTime uint64) *Buc
 
 // sampleCount is the number of slots
 // intervalInMs is the time length of sliding window
-// (intervalInMs%sampleCount != 0,verification has been completed by the caller)
+// sampleCount and intervalInMs must be positive and intervalInMs%sampleCount == 0,
+// the validation must be done before call NewBucketLeapArray
 func NewBucketLeapArray(sampleCount uint32, intervalInMs uint32) *BucketLeapArray {
 	bucketLengthInMs := intervalInMs / sampleCount
 	ret := &BucketLeapArray{

core/stat/base/leap_array.go

@@ -96,7 +96,9 @@ func NewAtomicBucketWrapArray(len int, bucketLengthInMs uint32, generator Bucket
 
 func (aa *AtomicBucketWrapArray) elementOffset(idx int) (unsafe.Pointer, bool) {
 	if idx >= aa.length || idx < 0 {
-		logging.Error(errors.Errorf("The index (%d) is out of bounds, length is %d.", idx, aa.length), "")
+		logging.Error(errors.New("array index out of bounds"),
+			"array index out of bounds in AtomicBucketWrapArray.elementOffset()",
+			"idx", idx, "arrayLength", aa.length)
 		return nil, false
 	}
 	basePtr := aa.base