Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Redesign naming's distro #3642

Closed
KomachiSion opened this issue Aug 19, 2020 · 0 comments
Closed

[Discussion] Redesign naming's distro #3642

KomachiSion opened this issue Aug 19, 2020 · 0 comments
Labels
kind/discussion Category issues related to discussion kind/refactor

Comments

@KomachiSion
Copy link
Collaborator

KomachiSion commented Aug 19, 2020

Is your feature request related to a problem? Please describe.

Currently, naming's distro contain features of syncTask manager, checksum(verify) data, and data store.
But I think data store should not be distro's features, so that it's data saved double (one is in ServiceManager, other is in DataStore)
So I want to mark ServiceManager as datasource or data store directly. And using datum key to trigger sync directly.

Describe the solution you'd like

Creating an DelaySyncTask in TaskPool. If there are multiple change during waiting, same key task should be merged in pool.

Before actually execute sync, getting data from data store.

image

Describe alternatives you've considered

About the checksum verify. There are other way to do. It is move to task module and do it automatically.

image

Additional context

I found that in config module TaskManager can be used by the new design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discussion Category issues related to discussion kind/refactor
Projects
None yet
Development

No branches or pull requests

1 participant