Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check field and protection threshold are confused #182

Closed
wyp12 opened this issue Oct 29, 2018 · 2 comments
Closed

Health check field and protection threshold are confused #182

wyp12 opened this issue Oct 29, 2018 · 2 comments
Assignees
Labels
contribution welcome good first issue Good for newcomers kind/user experience not necessarily an error but can be improved for user experience
Milestone

Comments

@wyp12
Copy link
Collaborator

wyp12 commented Oct 29, 2018

The health status field is "valid", When the protection threshold function is triggered, the health status field is forced to become true. In this case, the user cannot know the true health status of the machine.

  • Suggested optimization:
    A new field is added to the service level to indicate whether the protection threshold function is triggered.
    The instance level of the valid always returns the true machine health status

  • Issues to consider:
    The validation logic of the client protection threshold needs to be modified

@nkorange nkorange added the kind/user experience not necessarily an error but can be improved for user experience label Oct 29, 2018
@nkorange
Copy link
Collaborator

nkorange commented Nov 5, 2018

Will add a new flag to indicate if protect threshold is met.

@universefeeler
Copy link
Contributor

@wyp12 i will try to slove it

@nkorange nkorange added this to the 1.1.5 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome good first issue Good for newcomers kind/user experience not necessarily an error but can be improved for user experience
Projects
None yet
Development

No branches or pull requests

3 participants