Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What do these configuration properties mean? #1385

Closed
eacdy opened this issue Jun 16, 2019 · 2 comments
Closed

What do these configuration properties mean? #1385

eacdy opened this issue Jun 16, 2019 · 2 comments
Assignees
@nkorange
Labels
area/Document Category issues or prs related to document. kind/enhancement Category issues or prs related to enhancement.
Milestone
1.1.0

Comments

@eacdy
Copy link

eacdy commented Jun 16, 2019

Can we add some comment in application.properties? Especially for the configuration properties below:

nacos.naming.distro.taskDispatchThreadCount=1
nacos.naming.distro.taskDispatchPeriod=200
nacos.naming.distro.batchSyncKeyCount=1000
nacos.naming.distro.initDataRatio=0.9
nacos.naming.distro.syncRetryDelay=5000
nacos.naming.data.warmup=true
nacos.naming.expireInstance=true

I dont' know any of these until I dig into the source code.
@eacdy
Copy link
Author

eacdy commented Jun 16, 2019

@nkorange @loadchange @jameslcj

@eacdy eacdy changed the title What does these configuration properties mean? What do these configuration properties mean? Jun 16, 2019
@nkorange nkorange added area/Document Category issues or prs related to document. kind/enhancement Category issues or prs related to enhancement. labels Jun 17, 2019
@nkorange nkorange self-assigned this Jun 17, 2019
@nkorange nkorange added this to the 1.0.2 milestone Jun 17, 2019
@nkorange
Copy link
Collaborator

Quite reasonable, will do it.

@nkorange nkorange modified the milestones: 1.0.2, 1.1.0 Jun 28, 2019
@nkorange nkorange mentioned this issue Jul 6, 2019
Merged
5 tasks
@nkorange nkorange closed this as completed Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkorange nkorange

Labels
area/Document Category issues or prs related to document. kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@nkorange @eacdy