Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracer should support trace exception count for specific entry or context #453

Closed
sczyh30 opened this issue Jan 25, 2019 · 0 comments
Closed
Labels
kind/enhancement Category issues or prs related to enhancement.

Comments

@sczyh30
Copy link
Member

sczyh30 commented Jan 25, 2019

Issue Description

Type: enhancement

Describe what happened (or what feature you want)

Currently, we use Tracer.trace(xxx) to record the exception count. The trace method only supports tracing exception count for current entry in current context. In some circumstances this might not be enough. For example, in Dubbo adapter we generated two resources:

--SomeService
----SomeService:someMethod(xxx)

When biz exceptions are thrown, the Tracer.trace(xxx) can only add exception count for current entry (method entry), while the service entry is ignored. This causes the exception-based circuit breaking cannot take effect in the Dubbo service resource.

Describe what you expected to happen

The Tracer class should support trace exception count for specific entry or context. Adapters may improve their implementations.

Tell us your environment

Sentinel 1.4.1

@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

No branches or pull requests

1 participant