-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support adding prefix to Dubbo service resource name in Sentinel Dubbo Adapter #427
Comments
The resource name provided by the Dubbo adapter adds the Dubbo prefix.The resource name provided by the Dubbo adapter currently has no prefix, just the package path + class name. It is not intuitive to see that the Dubbo call is made when you see it in the console. Can I add a prefix to show the difference. For example, the service provider uses dubbo-provider, and the service consumer uses dubbo-consumer. |
Hi, thanks for your suggestion. For this, we need to consider compatibility with previous versions. Maybe we can add a property to control whether the resource name has a common prefix and configure the common prefix. |
thanks, it is good. which version of sentinel will provide the feature? |
Contribution is welcomed~ |
I have a question: If the dubbo service shows the prefix, then the configuration rules should be prefixed? |
If the Dubbo service resource is added with the prefix, then when we configure rules it should also be prefixed. This is not compatible with existing rules. |
So is it necessary to add the prefix? |
This will be introduced in 1.7.0. See #859 for details. |
Dubbo适配器提供的资源名目前没有前缀,只是包路径+类名。导致在控制台看到时不能直观的看出是Dubbo调用。可否增加前缀以示区别。比如服务提供者使用dubbo-provider,服务消费者使用dubbo-consumer
The text was updated successfully, but these errors were encountered: