Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeapArray currentWindow method‘s comment has problem #2875

Closed
ZhongJinHacker opened this issue Sep 10, 2022 · 1 comment · Fixed by #2876
Closed

LeapArray currentWindow method‘s comment has problem #2875

ZhongJinHacker opened this issue Sep 10, 2022 · 1 comment · Fixed by #2876
Labels
area/document Category issues or prs related to document. area/metrics Issues or PRs related to metrics and monitoring

Comments

@ZhongJinHacker
Copy link
Contributor

LeapArray currentWindow 方法注释与逻辑不符

130行: (3) Bucket is deprecated, then reset current bucket and clean all deprecated buckets.

实际上逻辑是重置了当前bucket,但并没有清理所有其他过期的buckets

130 line the commnet does not express the logic correctly,the logic does not clean all deprecated buckets. it just reset the current bucket。 it may mislead the people

Type: bug report

如果你们认为我描述的确实是有这个问题,请分配这个任务给我,我希望来修复这个问题

If you think my description is right, please assign this fix mission to me, I glad to fix it

@sczyh30 sczyh30 added area/document Category issues or prs related to document. area/metrics Issues or PRs related to metrics and monitoring labels Sep 13, 2022
@sczyh30
Copy link
Member

sczyh30 commented Sep 15, 2022

Thanks for reporting. The "clean" operation was indeed removed in the earlier version (see #47). The javadoc should be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/document Category issues or prs related to document. area/metrics Issues or PRs related to metrics and monitoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants