Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HTTPS url for -Dcsp.sentinel.dashboard.server attribute #1840

Closed
dshowing opened this issue Nov 4, 2020 · 1 comment · Fixed by #1896
Closed

Support HTTPS url for -Dcsp.sentinel.dashboard.server attribute #1840

dshowing opened this issue Nov 4, 2020 · 1 comment · Fixed by #1896
Labels
good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Milestone
1.8.1

Comments

@dshowing
Copy link

dshowing commented Nov 4, 2020

Issue Description

bug report

Describe what happened (or what feature you want)

当配置-Dcsp.sentinel.dashboard.server为指定地址，但这个地址会强制跳转https（443端口）时，会连接不到，对端收不到心跳包，请确认下

Describe what you expected to happen

请确认下能否使用https地址
@sczyh30
Copy link
Member

sczyh30 commented Nov 5, 2020

HTTPS is not supported yet. Contributions are welcomed!

@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Nov 5, 2020
@sczyh30 sczyh30 changed the title -Dcsp.sentinel.dashboard.server参数能否使用https协议地址？ Support HTTPS url for -Dcsp.sentinel.dashboard.server attribute Nov 5, 2020
@sczyh30 sczyh30 added the good first issue Good for newcomers label Nov 8, 2020
@polarbear567 polarbear567 mentioned this issue Dec 14, 2020
Merged
@sczyh30 sczyh30 added this to the 1.8.1 milestone Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
1.8.1
Development

Successfully merging a pull request may close this issue.

Support HTTPS url for -Dcsp.sentinel.dashboard.server attribute polarbear567/Sentinel
2 participants
@sczyh30 @dshowing