Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GIE/Physical] Return PhysicalPlan rather than JobRequest when Compiler call buildPhysicalPlan() function #2910

Closed
BingqingLyu opened this issue Jun 16, 2023 · 1 comment
Closed

[GIE/Physical] Return PhysicalPlan rather than JobRequest when Compiler call buildPhysicalPlan() function #2910

BingqingLyu opened this issue Jun 16, 2023 · 1 comment
Assignees
@BingqingLyu
Labels
component:gie

Comments

@BingqingLyu
Copy link
Collaborator

BingqingLyu commented Jun 16, 2023 •
edited
Loading

Describe the bug

As titled. When building a physical plan, compiler would call buildPhysicalPlan() function in ir core. However, currently, this function returns JobRequest, which is a Pegasus job request. Fix it by returning a PhysicalPlan, and let Compiler build a JobRequest if it is for Pegasus.
@BingqingLyu BingqingLyu self-assigned this Jun 16, 2023
@BingqingLyu BingqingLyu changed the title [GIE/Physical] Return PhysicalPlan rather than JobRequest when Compiler call buildPhysicalPlan function [GIE/Physical] Return PhysicalPlan rather than JobRequest when Compiler call buildPhysicalPlan() function Jun 16, 2023
@BingqingLyu
Copy link
Collaborator Author

Fixed in #2911 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BingqingLyu BingqingLyu

Labels
component:gie
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BingqingLyu