Skip to content

Commit 3606b85

Browse files
authored
Fixes the building failure of client wheel on Linux arm64 platform (#2780)
Simplify client package installation and ignore type annotation files. The changes make the `Makefile` more robust and avoid cluttering the `python` directory with `.pyi` files. Signed-off-by: Dongze Li <[email protected]>
1 parent fdc626e commit 3606b85

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

Makefile

+2-8
Original file line numberDiff line numberDiff line change
@@ -74,14 +74,8 @@ client: learning
7474
python3 -m pip install -r requirements.txt -r requirements-dev.txt --user && \
7575
export PATH=$(PATH):$(HOME)/.local/bin && \
7676
python3 setup.py build_ext --inplace --user
77-
if [[ "${ARCH}" == "aarch64" ]]; then \
78-
python3 setup.py bdist_wheel; \
79-
python3 -m pip install --user dist/*.whl; \
80-
rm -fr $(CLIENT_DIR)/build; \
81-
else \
82-
python3 -m pip install --user --editable $(CLIENT_DIR); \
83-
rm -rf $(CLIENT_DIR)/*.egg-info; \
84-
fi
77+
python3 -m pip install --user --no-build-isolation --editable $(CLIENT_DIRNT_DIR)
78+
rm -rf $(CLIENT_DIR)/*.egg-info
8579

8680
coordinator: client
8781
cd $(COORDINATOR_DIR) && \

python/.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ lib/
1313

1414
# Protobuf GRPC
1515
*.pb.*
16+
*.pyi*
1617
*_pb2.py
1718
*_pb2_grpc.py
1819

0 commit comments

Comments
 (0)