You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ci: add conventional checks for PR title and docs (#3054)
With this PR merged, new checks are introduced:
the PR titles should follow the [Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/), which in
the format of <type>(<scope>): <description>. e.g.,
- fix: Correct typo
- feat(interactive): Add support for g.V().outE().inV()
- refactor!: Drop support for Python 3.8
- feat(analytical): Add delta-version for PageRank
if the PR is in type of `feat(<scope>):`, then documentation must be
updated.
Copy file name to clipboardExpand all lines: docs/development/how_to_contribute.md
+39-1
Original file line number
Diff line number
Diff line change
@@ -109,7 +109,45 @@ Follow [our code style guide](./code_style_guide.md) to attain the proper code f
109
109
110
110
### Submitting Your Changes
111
111
112
-
See [our guide on how to submit a pull request](./how_to_submit_pr.md).
112
+
To submit your changes, you will need to open a pull request (PR) against the main repository. If you're new to GitHub, you can find instructions on how to do that in [GitHub's documentation](https://help.github.com/articles/creating-a-pull-request). GraphScope requires PR titles to follow a specific format (a.k.a., [Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/)), depending on the type of change you're making. The format is as follows:
113
+
114
+
**type(scope): brief desciption about the pr**
115
+
116
+
Below are some examples of the valid PR titles:
117
+
118
+
- fix: Correct typo
119
+
- feat(interactive): Add support for g.V().outE().inV()
120
+
- refactor!: Drop support for Python 3.8
121
+
- feat(analytical): Add delta-version for PageRank
122
+
123
+
````{note}
124
+
Note that since pull request titles only have a single line, you have to use ! to indicate breaking changes.
125
+
````
126
+
127
+
The **type** must be one of the following:
128
+
129
+
- build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
130
+
- ci: Changes to our CI configuration files and scripts
131
+
- docs: Documentation only changes
132
+
- feat: A new feature
133
+
- fix: A bug fix
134
+
- perf: A code change that improves performance
135
+
- refactor: A code change that neither fixes a bug nor adds a feature
136
+
- test: Adding missing tests or correcting existing tests
137
+
- chore: A routine task of development
138
+
139
+
The **scope** is optional. However, if it assigned, it must be one of the following:
140
+
- core
141
+
- python
142
+
- k8s
143
+
- coordinator
144
+
- one
145
+
- interactive
146
+
- insight
147
+
- analytical
148
+
- learning
149
+
150
+
In addtion to the conventional commit specification, we also require the PRs with feature update, (i.e., titled with feat:) should update the corresponding documentations. The repo depolyed a CI check to ensure this.
113
151
114
152
### Discussing and Keeping Your Pull Request Updated
0 commit comments