Better error message when requesting a block that isn't there.

[winder]

Summary

When a block is missing from the indexer (i.e. requesting a round we haven't reached yet), the error message says "SQL: no rows in result set". We should have a better message saying "Block not found."

Scope/Requirements

The API handler would catch the not found error and return the new error message.

Urgency/Relative Priority

Quick win, we should just do it.

[brianolson]

HTTP 404 would seem appropriate

[mxmauro]

Hi @winder , do you have an estimation when this will be implemented? Regards.

[winder]

@mxmauro unfortunately there's still a lot of other work ahead of this so we've been unable to get it into a sprint.

[mxmauro]

Ok no problem. But it is important to know it will be changed in some future. Thanks for the feedback.

[algojack]

This is a problem for us since we have logs and alerts on metrics. And this is polluting the logs and setting off 5xx alarms. Noisy alarms lead to alarm fatigue, which leads to ignoring more important alarms. Please prioritize this @yaovi-a