From 47f6d4487b7a8be12aa1c2ce4013b94c69c88d2f Mon Sep 17 00:00:00 2001 From: Gary Malouf <982483+gmalouf@users.noreply.github.com> Date: Tue, 3 Oct 2023 15:21:55 -0400 Subject: [PATCH] Remove flaky persistent peers test from wsNetwork (TestUpdatePhonebookAddresses covers this). --- network/wsNetwork_test.go | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/network/wsNetwork_test.go b/network/wsNetwork_test.go index 8159b6a898..099b04e895 100644 --- a/network/wsNetwork_test.go +++ b/network/wsNetwork_test.go @@ -4260,39 +4260,6 @@ func TestUpdatePhonebookAddresses(t *testing.T) { }) } -func TestUpdatePhonebookAddressesPersistentPeers(t *testing.T) { - partitiontest.PartitionTest(t) - - rapid.Check(t, func(t1 *rapid.T) { - nw := makeTestWebsocketNode(t) - // Generate a new set of relay domains - // Dont overlap with archive nodes previously specified, duplicates between them not stored in phonebook as of this writing - relayDomainsGen := rapid.SliceOfN(rapidgen.DomainOf(253, 63, "", nil), 0, 200) - relayDomains := relayDomainsGen.Draw(t1, "relayDomains") - - var persistentPeers []string - // Add an initial set of relay domains as Persistent Peers in the Phonebook, - persistentPeers = rapid.SliceOfN(rapidgen.DomainOf(253, 63, "", relayDomains), 0, 200).Draw(t1, "") - nw.phonebook.AddPersistentPeers(persistentPeers, string(nw.NetworkID), PhoneBookEntryRelayRole) - - // run updatePhonebookAddresses - nw.updatePhonebookAddresses(relayDomains, nil) - - // Check that entries are in fact in phonebook less any duplicates - dedupedRelayDomains := removeDuplicateStr(relayDomains, false) - - relayPeers := nw.GetPeers(PeersPhonebookRelays) - require.Equal(t, len(dedupedRelayDomains)+len(persistentPeers), len(relayPeers)) - - relayAddrs := make([]string, 0, len(relayPeers)) - for _, peer := range relayPeers { - relayAddrs = append(relayAddrs, peer.(HTTPPeer).GetAddress()) - } - - require.ElementsMatch(t, append(dedupedRelayDomains, persistentPeers...), relayAddrs) - }) -} - func removeDuplicateStr(strSlice []string, lowerCase bool) []string { allKeys := make(map[string]bool) var dedupStrSlice = make([]string, 0)