Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework pipeline process management #99

Closed
winder opened this issue Jun 12, 2023 · 1 comment
Closed

Rework pipeline process management #99

winder opened this issue Jun 12, 2023 · 1 comment

Comments

@winder
Copy link
Contributor

winder commented Jun 12, 2023

Subject of the issue

The pipeline object is managed using a context with a cancel function and a wait group. This setup is strange.

Rather than managing the process internal to the pipeline, Start() should be renamed to Run(), and Run() should be blocking. If the context is cancelled Run() can call Stop() automatically.

The caller would then use a waitgroup and run the pipeline in a go-routine if it wants to. Run() could also return the error directly rather than implementing setError and Error.

@winder
Copy link
Contributor Author

winder commented Aug 10, 2023

Closing in favor of #100

@winder winder closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant