Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(init): accept userToken at init() method #241

Merged
merged 3 commits into from
Jan 12, 2021

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Jan 11, 2021

This PR makes it accept userToken parameter at init() method, which enables users to initialize the insights client with the initial user token.

If it's given, it will not set anonymous user token in the cookie.

related: algolia/instantsearch#4608

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 11, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ea377ba:

Sandbox Source
Vanilla Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a sensible way to avoid using cookies

@eunjae-lee
Copy link
Contributor Author

@Haroenv I forgot the README. Can you give it a review? ea377ba

@eunjae-lee eunjae-lee merged commit 29216c6 into master Jan 12, 2021
@eunjae-lee eunjae-lee deleted the feat/init-user-token branch January 12, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants