chore(ts): avoid more ts-ignores #4817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ts-expect-error will error if it's no longer needed, so it's better in almost all cases. There's some moments where we need to keep ts-ignore though: - things that fail only with algoliasearch v3 or v4 - optional packages (places) - code that doesn't always error At the same time updated the algoliasearch-helper to a version that includes `showParentLevel` in the typings
Haroenv
requested review from
a team,
tkrugg and
shortcuts
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 934999b:
|
francoischalifour
approved these changes
Jul 30, 2021
| @@ -47,18 +48,20 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/answers/js/ | |||
| indexName: 'instant_search', | |||
| searchClient, | |||
| }); | |||
| search.helper = helper; | |||
There was a problem hiding this comment.
Why did we have to do this?
There was a problem hiding this comment.
createInitOptions gets the state from the InstantSearch instance (before it was undefined), in theory we could also have grabbed it from the helper argument, but that isn't such a big difference (usually they will be the same)
|
That's a satisfying PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ts-expect-error will error if it's no longer needed, so it's better in almost all cases. There's some moments where we need to keep ts-ignore though:
At the same time updated the algoliasearch-helper to a version that includes
showParentLevelin the typingspart of DX-2299